From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Allan Caffee <allan.caffee@gmail.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Nanako Shiraishi <nanako3@lavabit.com>
Subject: Re: [RFC/PATCH] graph API: Added logic for colored edges.
Date: Tue, 31 Mar 2009 12:26:58 +0200 [thread overview]
Message-ID: <49D1EFF2.303@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0903311210000.10279@pacific.mpi-cbg.de>
Johannes Schindelin schrieb:
> How about this function instead?
>
> static void strbuf_add_column(struct strbuf *sb,
> const struct column *column, const char *fmt, ...)
> {
> va_list ap;
>
> va_start(ap, fmt);
> if (column->color)
> strbuf_addstr(sb, column->color);
> strbuf_vaddf(sb, fmt, ap);
> if (column->color)
> strbuf_addstr(sb, GIT_COLOR_RESET);
> va_end(ap);
> }
>
> Hmm?
Except the strbuf_vaddf() is only in your private repository ;)
-- Hannes
next prev parent reply other threads:[~2009-03-31 10:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 10:05 [RFC] Colorization of log --graph Allan Caffee
2009-03-18 11:44 ` Johannes Schindelin
2009-03-19 16:59 ` Allan Caffee
2009-03-19 17:41 ` Johannes Schindelin
2009-03-19 21:48 ` Nanako Shiraishi
2009-03-20 19:13 ` Allan Caffee
2009-03-20 19:58 ` Jeff King
[not found] ` <20090321175726.GA6677@linux.vnet>
2009-03-30 14:13 ` [RFC/PATCH] graph API: Added logic for colored edges Allan Caffee
[not found] ` <cover.1238428115u.git.johannes.schindelin@gmx.de>
2009-03-30 15:49 ` [PATCH 1/2] graph.c: avoid compile warnings Johannes Schindelin
2009-03-30 15:58 ` Junio C Hamano
2009-03-30 16:14 ` Junio C Hamano
2009-03-30 15:49 ` [PATCH 2/2] --graph: respect --no-color Johannes Schindelin
2009-03-30 16:04 ` [RFC/PATCH] graph API: Added logic for colored edges Johannes Schindelin
2009-03-31 10:13 ` Johannes Schindelin
2009-03-31 10:26 ` Johannes Sixt [this message]
2009-03-31 12:09 ` Johannes Schindelin
2009-03-31 10:21 ` Johannes Schindelin
2009-03-20 20:13 ` [RFC] Colorization of log --graph Junio C Hamano
2009-03-18 16:52 ` Eric Raible
2009-03-18 17:04 ` Santi Béjar
2009-03-18 17:29 ` Eric Raible
2009-03-19 19:32 ` Markus Heidelberg
2009-03-19 19:52 ` Eric Raible
2009-03-19 20:04 ` Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D1EFF2.303@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=allan.caffee@gmail.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.