From: Wolfgang Grandegger <wg@grandegger.com>
To: linuxppc-dev@ozlabs.org
Cc: devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable
Date: Tue, 31 Mar 2009 14:49:09 +0200 [thread overview]
Message-ID: <49D21145.3060400@grandegger.com> (raw)
In-Reply-To: <20090331123727.853787299@denx.de>
Please *FORGET* this series of patches. Only the I2C related patches are
relevant but I accidentally sent out the complete patch stack :-(. I
will resent them in a second.
Sorry for any inconvenience this has caused.
Wolfgang.
Wolfgang Grandegger wrote:
> Following (most of) Grant's suggestions to my RFC:
>
> http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069820.html
>
> this new patch series now uses:
>
> - the I2c node property "fsl,preserve-clocking" to overtake the
> clock settings from the boot loader. The first patch provides this
> feature and can be applied *without* delay. This rest will take
> more time and discussion, I'm afraid :-(.
>
> - the OF match table to define the I2C clock properties, especially
> the source clock pre-scaler:
>
> static const struct of_device_id mpc_i2c_of_match[] = {
> {.compatible = "fsl,mpc5200b-i2c",
> .data = (void *)FSL_I2C_DEV_CLOCK_5200, },
> {.compatible = "fsl,mpc5200-i2c",
> .data = (void *)FSL_I2C_DEV_CLOCK_5200, },
> {.compatible = "fsl,mpc8313-i2c",
> .data = (void *)FSL_I2C_DEV_SEPARATE_DFSRR, },
> {.compatible = "fsl,mpc8543-i2c",
> .data = (void *)(FSL_I2C_DEV_SEPARATE_DFSRR |
> FSL_I2C_DEV_CLOCK_DIV2), },
> {.compatible = "fsl,mpc8544-i2c",
> .data = (void *)(FSL_I2C_DEV_SEPARATE_DFSRR |
> FSL_I2C_DEV_CLOCK_DIV23), },
> /* Backward compatibility */
> {.compatible = "fsl-i2c", },
> {},
> };
>
> The "data" field defines the relevant I2C flags.
>
> - arch-specific tables and functions to get the proper Freqency
> Divider Register (fdr). I added them to sysdev/fsl_soc.c for
> the MPC8xxx and to platforms/52xx/mpc52xx_common.c for the
> MPC52xx. This also solves the problem with arch-specific
> functions, e.g. for getting the bus frequency.
>
> - dev_dbg() and dev_info() to profit from a more descriptive output.
>
> Hope this solution is OK now?
>
> Thanks,
>
> Wolfgang.
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
>
next prev parent reply other threads:[~2009-03-31 12:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 12:37 [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 1/8] [PATCH 3/4] powerpc/85xx: Move gianfar mdio nodes under the Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 2/8] [PATCH 01/28] RTC: Add support for RX8025 chip Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 3/8] powerpc/85xx: Add support for the "socrates" board (MPC8544) Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 15:57 ` Grant Likely
2009-03-31 15:57 ` Grant Likely
2009-03-31 19:20 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 4/8] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 15:41 ` Grant Likely
2009-03-31 15:41 ` Grant Likely
2009-04-01 7:51 ` Wolfgang Grandegger
2009-04-01 13:30 ` Grant Likely
2009-04-01 13:30 ` Grant Likely
2009-04-01 13:41 ` Wolfgang Grandegger
2009-04-01 13:41 ` Wolfgang Grandegger
2009-04-01 13:55 ` Wolfgang Grandegger
[not found] ` <49D36F1F.2050107-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-04-01 13:55 ` Grant Likely
2009-04-01 13:55 ` Grant Likely
[not found] ` <fa686aa40904010655i73819214m795939e784889267-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-02 6:55 ` Wolfgang Grandegger
2009-04-02 6:55 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 23:04 ` David Gibson
2009-04-01 7:31 ` Wolfgang Grandegger
2009-04-01 11:09 ` David Gibson
2009-04-01 11:09 ` David Gibson
2009-04-01 11:59 ` Wolfgang Grandegger
2009-04-01 23:57 ` David Gibson
2009-04-01 12:30 ` Anton Vorontsov
2009-04-01 23:58 ` David Gibson
2009-03-31 12:37 ` [PATCH 7/8] Re: [PATCH 1/2] NAND: Add support for oob size 128 Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 12:37 ` [PATCH 8/8] NAND: Add support for NAND on the Socrates board Wolfgang Grandegger
2009-03-31 12:37 ` Wolfgang Grandegger
2009-03-31 12:49 ` Wolfgang Grandegger [this message]
2009-03-31 16:23 ` [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D21145.3060400@grandegger.com \
--to=wg@grandegger.com \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.