From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: RE: [PATCH] small adjustment to asm constraintsforc/s19400 Date: Tue, 31 Mar 2009 11:54:34 +0100 Message-ID: <49D2128A.76E4.0078.0@novell.com> References: <8FED46E8A9CA574792FC7AACAC38FE7701D4B7A421@PDSMSX501.ccr.corp.intel.com> <8FED46E8A9CA574792FC7AACAC38FE7701D4B7A7D8@PDSMSX501.ccr.corp.intel.com> <49D0A942.76E4.0078.0@novell.com> <8FED46E8A9CA574792FC7AACAC38FE7701D4EAF926@PDSMSX501.ccr.corp.intel.com> <49D1FD66.76E4.0078.0@novell.com> <0A882F4D99BBF6449D58E61AAFD7EDD6101840E9@pdsmsx502.ccr.corp.intel.com> <49D20950.76E4.0078.0@novell.com> <0A882F4D99BBF6449D58E61AAFD7EDD61018410D@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <0A882F4D99BBF6449D58E61AAFD7EDD61018410D@pdsmsx502.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Guanqun Lu , Kevin Tian Cc: "xen-devel@lists.xensource.com" , KeirFraser List-Id: xen-devel@lists.xenproject.org >>> "Tian, Kevin" 31.03.09 12:21 >>> >BTW, another question comes when I'm clearing the code. >in load_segments, fs/gs base MSRs are only updated for non 32-on-64 >domain. I guess that it's just for performance reason as 32bit guest=20 >doesn't require to switch gs base. I want to get your confirmation=20 >since in current low level context S3 resume code, we always restore=20 >those base MSRs even for 32-on-64 case. Correct - your code isn't performance sensitive, so keeping it simple is probably preferable. load_segments() sits in the context switch code, and thus it tries to avoid things not needed for a particular guest. Jan