From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, benh@kernel.crashing.org, petkovbb@gmail.com
Subject: Re: [PATCH] ide: turn selectproc() method into dev_select() method (take 5)
Date: Tue, 31 Mar 2009 22:19:32 +0400 [thread overview]
Message-ID: <49D25EB4.7060608@ru.mvista.com> (raw)
In-Reply-To: <200903262118.14931.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>Turn selectproc() method into dev_select() method by teaching it to write to the
>>device register and moving it from 'struct ide_port_ops' to 'struct ide_tp_ops'.
>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>>---
>>Changes since the 4th take:
>>- added ide_dev_select() declaration to <linux/ide.h> at last... :-/
> Seems like putting a bit more time into re-auditing the whole patch after
> first issues are discovered/fixed wouldn't hurt...
What actually helped was actully compiling the patch. :-)
> and yes, the same can be said about re-reviewing it in this case...
;-)
MBR, Sergei
next prev parent reply other threads:[~2009-03-31 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 11:39 [PATCH] ide: turn selectproc() method into dev_select() method (take 5) Sergei Shtylyov
2009-03-26 20:18 ` Bartlomiej Zolnierkiewicz
2009-03-31 18:19 ` Sergei Shtylyov [this message]
2009-03-31 18:19 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D25EB4.7060608@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.