From: Benny Halevy <bhalevy@panasas.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: NFS list <linux-nfs@vger.kernel.org>,
pNFS Mailing List <pnfs@linux-nfs.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [pnfs] 3-word attributes encoding
Date: Tue, 31 Mar 2009 21:36:08 +0300 [thread overview]
Message-ID: <49D26298.6070507@panasas.com> (raw)
In-Reply-To: <20090331014439.GA7273@fieldses.org>
On Mar. 31, 2009, 4:44 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Mon, Mar 30, 2009 at 05:37:37PM +0300, Benny Halevy wrote:
>> Bruce,
>>
>> As I mentioned in a reply to Trond,
>> "nfsd41: support for 3-word long attribute bitmask"
>> changes the server fattr encoding logic so it may send
>> back a bitmap of length 1, even if the client sent a
>> bitmap of length 2, if the second word of the bitmap
>> is zero. Although I think this a valid implementation
>> and other servers may do the same, it seems sub-optimal
>> for the client's decoding of acl of fs_locations.
>
> "suboptimal" means it does some extra memcpy'ing?
Yes, I believe so.
>
>> It's pretty easy to revert to the old behavior on the server
>> by always returning at least two bitmap words, or, if we
>> keep the bitmap length, not just the val, in nfsd4_decode_bitmap
>> we can return a bitmap of the same length in the reply.
>
> Odd thing to have to do, but OK. --b.
What would you prefer to do?
Revert to old behavior by returning at least two bitmap words
or use the args bitmap length for encoding the res?
Benny
>
>> Let me know what you think...
>>
>> Other than that,
>> git://linux-nfs.org/~bhalevy/linux-pnfs.git nfsd41-for-2.6.30
>> holds version 3 of the nfsd41 patchset, rebased onto your
>> update for-2.6.30 branch, and with these cleanup patches squashed-in:
>>
>> [PATCH 1/3] SQUASHME: get callback minorversion from fore channel's
>> [PATCH 2/3] SQUASHME: nfsd41: use nfsd4_cb_sequence for callback minorversion
>> [PATCH 3/3] SQUASHME: Revert "sunrpc: add cl_private field to struct rpc_clnt"
>>
>> Benny
>> _______________________________________________
>> pNFS mailing list
>> pNFS@linux-nfs.org
>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
next prev parent reply other threads:[~2009-03-31 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 14:37 3-word attributes encoding Benny Halevy
2009-03-31 1:44 ` [pnfs] " J. Bruce Fields
2009-03-31 18:36 ` Benny Halevy [this message]
2009-03-31 19:42 ` J. Bruce Fields
2009-03-31 20:00 ` Benny Halevy
2009-04-01 16:19 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D26298.6070507@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.