From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: spinlock requests (was RE: [Patch] don't spin with irq disabled) Date: Tue, 31 Mar 2009 14:16:11 -0700 Message-ID: <49D2881B.7030303@goop.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Dan Magenheimer , Juergen Gross , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > I suspect the existing uses of rwlock in Xen actually are because that > seemed a natural fit for the code -- obvious split between reader and writer > critical sections -- rather than because of excessive serialisation if using > a normal spinlock. I strongly disbelieve that lock acquire/release is a > significant performance bottleneck for us right now. > Aren't rwlocks sufficiently less efficient than spinlocks that you'd tend to use the latter if you don't think contention is an issue? J