All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chrissie Caulfield <ccaulfie@redhat.com>
To: linux-lvm@redhat.com
Subject: Re: [linux-lvm] Call dlm_release_lockspace with force=1 in	clvmd-corosync.c
Date: Wed, 01 Apr 2009 08:52:18 +0100	[thread overview]
Message-ID: <49D31D32.70907@redhat.com> (raw)
In-Reply-To: <1cafab770903311911p63f962afybfd39137e61344d1@mail.gmail.com>

Xinwei Hu wrote:
> Hi all,
> 
>     All calls to dlm_release_lockspace in clvmd-corosync.c use
> force=0. This may cause the problem when
> the node is the "lock master" of lockspace, the lockspace won't be
> release then, and there'll be no any error
> information from libdlm.
> 
>     Issues' found and analysied by Lars Marowsky-Bree and David Teigland.
> 
>     The patch tries to call dlm_release_lockspace with force = 1 in all cases.
> 
>     Please consider it for inclusion.


You're right (as usual). Force should also be set to 1 for consistency
with clvmd-cman.

The patch is now in CVS

Thank you.

Chrissie

      reply	other threads:[~2009-04-01  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01  2:11 [linux-lvm] Call dlm_release_lockspace with force=1 in clvmd-corosync.c Xinwei Hu
2009-04-01  7:52 ` Chrissie Caulfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D31D32.70907@redhat.com \
    --to=ccaulfie@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.