All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Jeff Garzik <jeff@garzik.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Avishay Traeger <avishay@gmail.com>,
	open-osd <osd-dev@open-osd.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: [osd-dev] [PATCH 6/8] exofs: super_operations and	file_system_type
Date: Wed, 01 Apr 2009 11:05:21 +0300	[thread overview]
Message-ID: <49D32041.4090009@panasas.com> (raw)
In-Reply-To: <49D2665A.9090500@panasas.com>

On 03/31/2009 09:52 PM, Benny Halevy wrote:
> On Mar. 31, 2009, 11:04 +0300, Andrew Morton <akpm@linux-foundation.org> wrote:
>> ~0 is signed 0xffffffff.
>>
>> When assigning to a u64 it gets signed extended to signed
>> 0xffffffffffffffff and then converted to unsigned 0xffffffffffffffff.
> 
> Right (I think, I'm not sure in what order)
> 
>> I think.  Just as with plain old "-1".  Perhaps using plain old "-1"
>> would be clearer here.
> 
> or maybe ~0ULL or ~(uint64_t)0 to be extremely anal about it.
> 
> Benny
> 

There is only one right way => ULLONG_MAX. Takes care of the human factor
too. (BTW that one is defined (~0ULL))

Thanks
Boaz


  reply	other threads:[~2009-04-01  8:07 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 17:45 [PATCHSET 0/8 version 4] exofs for kernel 2.6.30 Boaz Harrosh
2009-03-18 17:45 ` Boaz Harrosh
2009-03-18 17:57 ` [PATCH 1/8] exofs: Kbuild, Headers and osd utils Boaz Harrosh
2009-03-31  8:04   ` Andrew Morton
2009-03-31  8:57     ` Boaz Harrosh
2009-03-18 17:57 ` Boaz Harrosh
2009-03-18 17:58 ` [PATCH 2/8] exofs: file and file_inode operations Boaz Harrosh
2009-03-18 17:58   ` Boaz Harrosh
2009-03-31  8:04   ` Andrew Morton
2009-03-31  8:58     ` Boaz Harrosh
2009-03-18 18:01 ` [PATCH 3/8] exofs: symlink_inode and fast_symlink_inode operations Boaz Harrosh
2009-03-18 18:01   ` Boaz Harrosh
2009-03-18 18:04 ` [PATCH 4/8] exofs: address_space_operations Boaz Harrosh
2009-03-18 18:04   ` Boaz Harrosh
2009-03-22 10:22   ` Marcin Slusarz
2009-03-22 10:41     ` Boaz Harrosh
2009-03-22 13:58   ` [PATCH 4/8 ver5] " Boaz Harrosh
2009-03-22 13:58     ` Boaz Harrosh
2009-03-31  8:04     ` Andrew Morton
2009-03-31  9:04       ` Boaz Harrosh
2009-03-31 10:15         ` Andrew Morton
2009-03-31 10:27           ` Boaz Harrosh
2009-03-18 18:08 ` [PATCH 5/8] exofs: dir_inode and directory operations Boaz Harrosh
2009-03-18 18:08   ` Boaz Harrosh
2009-03-31  8:04   ` Andrew Morton
2009-03-31 10:22     ` Boaz Harrosh
2009-03-18 18:09 ` [PATCH 6/8] exofs: super_operations and file_system_type Boaz Harrosh
2009-03-18 18:09   ` Boaz Harrosh
2009-03-31  8:04   ` Andrew Morton
2009-03-31 10:29     ` Boaz Harrosh
2009-03-31 18:52     ` [osd-dev] " Benny Halevy
2009-04-01  8:05       ` Boaz Harrosh [this message]
2009-04-01  9:06         ` Benny Halevy
2009-03-18 18:10 ` [PATCH 7/8] exofs: Documentation Boaz Harrosh
2009-03-18 18:10   ` Boaz Harrosh
2009-03-21 13:26   ` Evgeniy Polyakov
2009-03-22  8:42     ` Boaz Harrosh
2009-03-18 18:11 ` [PATCH 8/8] fs: Add exofs to Kernel build Boaz Harrosh
2009-03-18 18:11 ` Boaz Harrosh
2009-03-23 13:06 ` [PATCHSET 0/8 version 4] exofs for kernel 2.6.30 Boaz Harrosh
2009-03-23 13:06   ` Boaz Harrosh
2009-03-24  9:07 ` Boaz Harrosh
2009-03-30 21:22 ` Andrew Morton
2009-03-31  3:01   ` Stephen Rothwell
2009-03-31  7:13     ` Evgeniy Polyakov
2009-03-31  7:20   ` Boaz Harrosh
2009-03-31  7:20     ` Boaz Harrosh
2009-03-31  7:41     ` Boaz Harrosh
2009-03-31  8:04       ` Andrew Morton
2009-04-01  9:23 ` Jeff Garzik
2009-04-01 11:21   ` Boaz Harrosh
2009-04-02  0:39     ` Jeff Garzik
2009-04-02 12:49       ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D32041.4090009@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=avishay@gmail.com \
    --cc=bhalevy@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jeff@garzik.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.