From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lp2Gv-0006uU-J1 for mharc-grub-devel@gnu.org; Wed, 01 Apr 2009 11:22:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lp2Gt-0006tb-QM for grub-devel@gnu.org; Wed, 01 Apr 2009 11:22:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lp2Gp-0006sE-CC for grub-devel@gnu.org; Wed, 01 Apr 2009 11:22:31 -0400 Received: from [199.232.76.173] (port=59691 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lp2Gp-0006sB-6b for grub-devel@gnu.org; Wed, 01 Apr 2009 11:22:27 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:39650 helo=jenni1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lp2Go-0001iU-MJ for grub-devel@gnu.org; Wed, 01 Apr 2009 11:22:27 -0400 Received: from [192.168.1.102] (84.248.105.254) by jenni1.inet.fi (8.5.014) id 49D075A8002043DE for grub-devel@gnu.org; Wed, 1 Apr 2009 18:22:22 +0300 Message-ID: <49D38692.9080201@nic.fi> Date: Wed, 01 Apr 2009 18:21:54 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: The development of GRUB 2 References: <49C63395.9090304@gmail.com> <200904012252.26655.okuji@enbug.org> <20090401141932.GA28777@thorin> <200904012342.22787.okuji@enbug.org> <49D38446.6030302@gmail.com> In-Reply-To: <49D38446.6030302@gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Move loader.c out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2009 15:22:32 -0000 phcoder wrote: > This usage case isn't the main target case. If you embed the loader > (which tend to be quite big) then you already have an overhead from > loader module. Why are you so concerned with overhead of boot.mod? > But on the other hand this forces all the people in other cases to have > boot code in core.img. I want to add preboot hooks and don't want > increment size of kernel. multiboot.mod currently increases the size by > around 11KB. And my patch doesn't restrict you from putting loader in > core.img in any way Even if you add the preboot hooks there, it should only cause size affect in couple of bytes for uncompressed image. Like in following "sketch": ... preboot_handler_address: dd 0 ... cmp [preboot_handler_address], 0 je no_preboot_handler call [preboot_handler_address] no_preboot_handler: