From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lp2e5-0005AR-Ry for mharc-grub-devel@gnu.org; Wed, 01 Apr 2009 11:46:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lp2e3-00059s-Uo for grub-devel@gnu.org; Wed, 01 Apr 2009 11:46:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lp2dz-00057U-C6 for grub-devel@gnu.org; Wed, 01 Apr 2009 11:46:27 -0400 Received: from [199.232.76.173] (port=35541 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lp2dz-00057R-4Q for grub-devel@gnu.org; Wed, 01 Apr 2009 11:46:23 -0400 Received: from mail-bw0-f167.google.com ([209.85.218.167]:44960) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lp2dy-000500-Kn for grub-devel@gnu.org; Wed, 01 Apr 2009 11:46:22 -0400 Received: by bwz11 with SMTP id 11so91086bwz.42 for ; Wed, 01 Apr 2009 08:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=3pSILHLorWZSWb7PU/BA8N7dSairMoLkQFg35uF7dY0=; b=v4dgnZ62bmZrhMzTIbav8KPoyf7zwFzsykdGH71AftsYpb+A3z2vIUi8yXgf2A+HSA 8UzGpOIkzZ1eZLbKdlkgAMCodstksOpMq3z2/L33+wYyGEFSUqH6F4OIBQy2aBXpqo/K ClheUTEtggZqGnV7gR7JV5Y/4/ICnCQVNCq9o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=gI6eumcMSq/lqtWqwRRk0+xfYXSgBR34eT0zLsRZWHi6d/yOglYRc1k1YrQ6Xx2N6V B0ZnUU5cK6amXMCs7UcpotNu+kl8MfwafwKCed0iglxJF4jD16Hre5CFReGjqMJLWO5l zyCKnhN2o1zj2vphQM94Tt1ytKi5NwqnXD+94= Received: by 10.223.126.145 with SMTP id c17mr6339946fas.16.1238600781402; Wed, 01 Apr 2009 08:46:21 -0700 (PDT) Received: from ?82.130.80.14? (hg-public-dock-14-dhcp.ethz.ch [82.130.80.14]) by mx.google.com with ESMTPS id z10sm32718fka.13.2009.04.01.08.46.20 (version=SSLv3 cipher=RC4-MD5); Wed, 01 Apr 2009 08:46:21 -0700 (PDT) Message-ID: <49D38C4C.4000407@gmail.com> Date: Wed, 01 Apr 2009 17:46:20 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49C63395.9090304@gmail.com> <200904012252.26655.okuji@enbug.org> <20090401141932.GA28777@thorin> <200904012342.22787.okuji@enbug.org> <49D38446.6030302@gmail.com> <49D38692.9080201@nic.fi> In-Reply-To: <49D38692.9080201@nic.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Move loader.c out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2009 15:46:28 -0000 I was thinking about something more finished like the possibility of handling multiple preboot and to undo the operations in case of failed or returned boot. Potentially it could be moved to a separate module but it results in a reverse dependency and somewhat ugly code Vesa Jääskeläinen wrote: > phcoder wrote: >> This usage case isn't the main target case. If you embed the loader >> (which tend to be quite big) then you already have an overhead from >> loader module. Why are you so concerned with overhead of boot.mod? >> But on the other hand this forces all the people in other cases to have >> boot code in core.img. I want to add preboot hooks and don't want >> increment size of kernel. multiboot.mod currently increases the size by >> around 11KB. And my patch doesn't restrict you from putting loader in >> core.img in any way > > Even if you add the preboot hooks there, it should only cause size > affect in couple of bytes for uncompressed image. > > Like in following "sketch": > > ... > > preboot_handler_address: dd 0 > > ... > > cmp [preboot_handler_address], 0 > > je no_preboot_handler > > call [preboot_handler_address] > > no_preboot_handler: > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko