From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, oliver@neukum.org
Subject: Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe
Date: Thu, 02 Apr 2009 10:02:18 -0500 [thread overview]
Message-ID: <49D4D37A.50504@lwfinger.net> (raw)
In-Reply-To: <20090402100223.GA30905@gondor.apana.org.au>
Herbert Xu wrote:
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> @@ -796,7 +795,7 @@ static int kaweth_start_xmit(struct sk_b
>>
>> int res;
>>
>> - spin_lock(&kaweth->device_lock);
>> + spin_lock_irq(&kaweth->device_lock);
>
> Should be irqsave unless you don't expect to be called via netpoll.
The .ndo_poll_controller callback is left at NULL in this driver. I believe the
patch to be OK.
Larry
next prev parent reply other threads:[~2009-04-02 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 15:28 [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe Larry Finger
2009-04-02 8:10 ` David Miller
2009-04-02 10:02 ` Herbert Xu
2009-04-02 15:02 ` Larry Finger [this message]
2009-04-02 15:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D4D37A.50504@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.