From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
nhorman@tuxdriver.com, zbr@ioremap.net, netdev@vger.kernel.org,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org
Subject: Re: [Patch 4/5] Network Drop Monitor: Adding drop monitor implementation & Netlink protocol
Date: Thu, 02 Apr 2009 17:14:50 +0200 [thread overview]
Message-ID: <49D4D66A.50101@trash.net> (raw)
In-Reply-To: <20090402150908.GA1382@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, Apr 02, 2009 at 05:06:40PM +0200, Patrick McHardy wrote:
>> Yes, that should always work. For new stuff I think we should try
>> to avoid encapsulating larger structures in single attributes though
>> since it forces us to do copy everything, instead of just the types
>> that really require it (and the padding issues in case of at least
>> non-priviledged interfaces).
>
> Are there any situations where we want to use a struct? Perhaps
> we can just ban it altogether for new code?
I'd prefer that as well. The only reason to do this is to save a few
bytes and cycles for attribute encapsulation. I don't think this
matters at all, judging by the fact that I've never seen a userspace
implementation using message batching, the current users don't seem
to care about performance *that* much.
next prev parent reply other threads:[~2009-04-02 15:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 17:04 [Patch 4/5] Network Drop Monitor: Adding drop monitor implementation & Netlink protocol Neil Horman
2009-03-03 18:19 ` Evgeniy Polyakov
2009-03-03 19:21 ` Neil Horman
2009-03-03 22:14 ` David Miller
2009-03-03 22:16 ` David Miller
2009-03-04 10:06 ` Patrick McHardy
2009-03-04 11:00 ` David Miller
2009-04-02 9:39 ` Herbert Xu
2009-04-02 9:50 ` David Miller
2009-04-02 9:52 ` David Miller
2009-04-02 9:59 ` Herbert Xu
2009-04-02 14:42 ` Patrick McHardy
2009-04-02 14:45 ` Herbert Xu
2009-04-02 14:57 ` Patrick McHardy
2009-04-02 14:59 ` Herbert Xu
2009-04-02 15:06 ` Patrick McHardy
2009-04-02 15:09 ` Herbert Xu
2009-04-02 15:14 ` Patrick McHardy [this message]
2009-04-02 15:30 ` Herbert Xu
2009-04-05 9:59 ` David Miller
2009-04-06 13:21 ` Patrick McHardy
2009-06-10 8:08 ` David Miller
2009-06-10 10:35 ` Patrick McHardy
2009-04-05 9:57 ` David Miller
2009-04-05 9:56 ` David Miller
2009-04-05 9:54 ` David Miller
2009-03-04 11:44 ` Neil Horman
2009-03-05 19:27 ` Neil Horman
2009-03-11 16:17 ` David Miller
2009-03-11 19:51 ` Neil Horman
2009-03-13 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D4D66A.50101@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.