All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: How does rfkill work?
Date: Thu, 02 Apr 2009 10:22:27 -0500	[thread overview]
Message-ID: <49D4D833.9070107@lwfinger.net> (raw)
In-Reply-To: <1238684527.4141.63.camel@johannes.local>

Johannes Berg wrote:
> On Thu, 2009-04-02 at 09:44 -0500, Larry Finger wrote:
>=20
>>> Can you check the contents of
>>> 	/sys/class/leds/b43legacy-...::radio/trigger
>>> please?
>> The first thing I noticed is that "radio" gets truncated to "rad", t=
hus the file
>> is /sys/class/leds/b43legacy-phy0\:\:rad/trigger,
>=20
> Cute. Must be that the limit is 20 bytes (19+NUL) in the buffer it us=
es
> in led core code.
>=20
>>  with contents "none ide-disk
>> ADP1-online BAT0-charging-or-full BAT0-charging BAT0-full phy0rx phy=
0tx
>> phy0assoc phy0radio [(]". I unloaded and reloaded the driver and fou=
nd that the
>> "[(]" characters changed to "[=EF=BF=BDW[=EF=BF=BD]". It appears tha=
t something is putting
>> garbage in that file.
>=20
> Ouch. That's bad. I'll try to figure it out. I don't see how my patch
> changes this -- does this happen without my patch too?

Without your "rfkill rewrite" patch, but with "rfkill-remove-unused-cod=
e",
"rfkill-remove-deprecated", and "rfkill-remove-user-claim" patches, the=
 file
/sys/class/..../trigger contains "none ide-disk BAT0-charging-or-full
BAT0-charging BAT0-full ADP1-online phy0rx phy0tx phy0assoc phy0radio [=
rfkill0]"

Now I know what should be inside the [].

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-04-02 15:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  4:59 How does rfkill work? Larry Finger
2009-04-02  9:56 ` Johannes Berg
2009-04-02 14:44   ` Larry Finger
2009-04-02 15:02     ` Johannes Berg
2009-04-02 15:22       ` Larry Finger [this message]
2009-04-02 15:55         ` Johannes Berg
2009-04-02 16:27         ` Johannes Berg
2009-04-02 18:18           ` Larry Finger
2009-04-02 18:28             ` Johannes Berg
2009-04-03 15:15               ` Richard Purdie
2009-04-03 19:22                 ` Johannes Berg
2009-04-02 18:29             ` Johannes Berg
2009-04-02 18:42               ` Larry Finger
2009-04-02 18:48                 ` Johannes Berg
2009-04-02 18:57                   ` Johannes Berg
2009-04-02 20:36                     ` Larry Finger
2009-04-02 20:50                       ` Johannes Berg
2009-04-02 21:24                         ` Larry Finger
2009-04-02 21:39                           ` Johannes Berg
2009-04-02 21:59                             ` Larry Finger
2009-04-02 22:09                               ` Johannes Berg
2009-04-03  4:37                       ` Marcel Holtmann
2009-04-03  4:57                         ` Larry Finger
2009-04-03  5:09                         ` Kay Sievers
2009-04-03  4:35       ` Marcel Holtmann
2009-04-03  9:01         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D4D833.9070107@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.