All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takahiro Yasui <tyasui@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC PATCH 6/7] individual lvm command settings
Date: Thu, 02 Apr 2009 13:19:31 -0400	[thread overview]
Message-ID: <49D4F3A3.1090605@redhat.com> (raw)
In-Reply-To: <49D3D9F5.902@redhat.com>

Several lvm commands should not work based on metadata cache data. They
need to scan real metadata on devices. lvm commands with MCACHE_DISABLE
flag do not use metadata cache.

Currently the metadata cache feature is disabled in the following commands.

  * scan commands: vgscan and lvscan
      pvscan destroys lvmcache before its procedure, and MCACHE_DISABLE
      flag is not needed.

  * physical volume commands: pvdisplay, pvs
      Metadata cache files contain physical volume data which belong to
      a volume group, and orphan physical volumes can not be handled.
      To support these volumes, a kind of orphan physical volume cache
      need to be introduced.

As a next step, I'm planning to set MCACHE_CLEANUP flag to vgscan command
to refresh all metadata cache files in the cache directory.


Signed-off-by: Takahiro Yasui <tyasui@redhat.com>
---
 tools/commands.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: LVM2.02.46-cvs-20090324/tools/commands.h
===================================================================
--- LVM2.02.46-cvs-20090324.orig/tools/commands.h
+++ LVM2.02.46-cvs-20090324/tools/commands.h
@@ -390,7 +390,7 @@ xx(lvs,
 
 xx(lvscan,
    "List all logical volumes in all volume groups",
-   0,
+   MCACHE_DISABLE,
    "lvscan " "\n"
    "\t[-a|--all]\n"
    "\t[-b|--blockdevice] " "\n"
@@ -497,7 +497,7 @@ xx(pvdata,
 
 xx(pvdisplay,
    "Display various attributes of physical volume(s)",
-   0,
+   MCACHE_DISABLE,
    "pvdisplay\n"
    "\t[-c|--colon]\n"
    "\t[-d|--debug]\n"
@@ -571,7 +571,7 @@ xx(pvremove,
 
 xx(pvs,
    "Display information about physical volumes",
-   0,
+   MCACHE_DISABLE,
    "pvs" "\n"
    "\t[--aligned]\n"
    "\t[-a|--all]\n"
@@ -925,7 +925,7 @@ xx(vgs,
 
 xx(vgscan,
    "Search for all volume groups",
-   0,
+   MCACHE_DISABLE,
    "vgscan "
    "\t[-d|--debug]\n"
    "\t[-h|--help]\n"






  parent reply	other threads:[~2009-04-02 17:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <49D3D9F5.902@redhat.com>
2009-04-02 17:19 ` [RFC PATCH 1/7] remove device scan from _text_create_text_instance Takahiro Yasui
2009-04-02 17:19 ` [RFC PATCH 2/7] rename _has_scanned to _need_scan Takahiro Yasui
2009-04-02 17:19 ` [RFC PATCH 3/7] separate metadata parse and verification Takahiro Yasui
2009-04-02 17:19 ` [RFC PATCH 4/7] support metadata cache feature Takahiro Yasui
2009-04-02 17:19 ` [RFC PATCH 5/7] add metadata cache interface Takahiro Yasui
2009-04-02 17:19 ` Takahiro Yasui [this message]
2009-04-02 17:19 ` [RFC PATCH 7/7] introduce metadata cache feature Takahiro Yasui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D4F3A3.1090605@redhat.com \
    --to=tyasui@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.