From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Network AT91 AVR32: generic way of addressing USRIO register layout
Date: Thu, 02 Apr 2009 15:02:31 -0700 [thread overview]
Message-ID: <49D535F7.6040300@gmail.com> (raw)
In-Reply-To: <20090402202856.GH15621@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:41 Mon 23 Mar , Haavard Skinnemoen wrote:
>
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>
>>> On 09:58 Mon 23 Mar , Nicolas Ferre wrote:
>>>
>>>> The MACB IP used by AVR32 & AT91 have two different layout for USRIO
>>>> register. We have to differentiate this in the driver code.
>>>> No more cpu specific #ifdefs in driver: we manage a
>>>> configuration variable.
>>>>
>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>>>>
>>> Ack-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>>
>>> Haavard is ok for you too?
>>>
>> Sure.
>>
>> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
>>
> Ben is ok for you?
>
It's definitely an improvement, although I'm not fond of placing the
conditional macro in the header file. Overall OK, though. I'll pick it up.
regards,
Ben
prev parent reply other threads:[~2009-04-02 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 8:58 [U-Boot] [PATCH] Network AT91 AVR32: generic way of addressing USRIO register layout Nicolas Ferre
2009-03-23 9:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-23 9:41 ` Haavard Skinnemoen
2009-04-02 20:28 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-02 22:02 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D535F7.6040300@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.