Re: [pnfs] [PATCH 22/22] SQUASHME: nfsd41 drop parens in nfsd4_is_solo_sequence call

[Benny Halevy <bhalevy@panasas.com>]

On Apr. 03, 2009, 3:20 +0300, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> March 31 review comments.
> squash into nfsd41: non-page DRC for solo sequence responses
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  include/linux/nfsd/xdr4.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/nfsd/xdr4.h b/include/linux/nfsd/xdr4.h
> index 3514f00..03e7025 100644
> --- a/include/linux/nfsd/xdr4.h
> +++ b/include/linux/nfsd/xdr4.h
> @@ -495,8 +495,8 @@ static inline int nfsd4_is_solo_sequence(struct nfsd4_compoundres *resp)
>  
>  static inline int nfsd4_not_cached(struct nfsd4_compoundres *resp)
>  {
> -	return (resp->cstate.slot->sl_cache_entry.ce_cachethis == 0 ||
> -			nfsd4_is_solo_sequence(resp));
> +	return resp->cstate.slot->sl_cache_entry.ce_cachethis == 0 ||

since ce_cachethis is boolean rather than numeric, how about using "!"
rather than "== 0"?

Benny

> +			nfsd4_is_solo_sequence(resp);
>  }
>  
>  #define NFS4_SVC_XDRSIZE		sizeof(struct nfsd4_compoundargs)