From: Zhaolei <zhaolei@cn.fujitsu.com>
To: "Steven Rostedt ;" <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] ftrace: Correct a text align for event format output
Date: Fri, 03 Apr 2009 18:24:46 +0800 [thread overview]
Message-ID: <49D5E3EE.70201@cn.fujitsu.com> (raw)
If we cat debugfs/tracing/events/ftrace/bprint/format, we'll see:
name: bprint
ID: 6
format:
field:unsigned char common_type; offset:0; size:1;
field:unsigned char common_flags; offset:1; size:1;
field:unsigned char common_preempt_count; offset:2; size:1;
field:int common_pid; offset:4; size:4;
field:int common_tgid; offset:8; size:4;
field:unsigned long ip; offset:12; size:4;
field:char * fmt; offset:16; size:4;
field: char buf; offset:20; size:0;
print fmt: "%08lx (%d) fmt:%p %s"
There is a redundant blank before char buf, and it need to be deleted.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
kernel/trace/trace_export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
index 4d9952d..07a22c3 100644
--- a/kernel/trace/trace_export.c
+++ b/kernel/trace/trace_export.c
@@ -40,7 +40,7 @@
#undef TRACE_FIELD_ZERO_CHAR
#define TRACE_FIELD_ZERO_CHAR(item) \
- ret = trace_seq_printf(s, "\tfield: char " #item ";\t" \
+ ret = trace_seq_printf(s, "\tfield:char " #item ";\t" \
"offset:%u;\tsize:0;\n", \
(unsigned int)offsetof(typeof(field), item)); \
if (!ret) \
--
1.5.5.3
next reply other threads:[~2009-04-03 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 10:24 Zhaolei [this message]
2009-04-03 10:26 ` [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage_*.h Zhaolei
2009-04-07 1:54 ` Steven Rostedt
2009-04-08 7:04 ` Jiaying Zhang
[not found] ` <5df78e1d0904072328v11e03131y5256d5c2ba9c03d@mail.gmail.com>
2009-04-08 7:04 ` Zhaolei
2009-04-08 7:16 ` Jiaying Zhang
2009-04-16 14:55 ` Steven Rostedt
2009-04-17 0:31 ` Zhaolei
2009-04-07 1:50 ` [PATCH 1/2] ftrace: Correct a text align for event format output Steven Rostedt
2009-04-07 13:13 ` [tip:tracing/urgent] " Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D5E3EE.70201@cn.fujitsu.com \
--to=zhaolei@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.