From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LpkhL-00076W-KX for mharc-grub-devel@gnu.org; Fri, 03 Apr 2009 10:48:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LpkhJ-00076M-KP for grub-devel@gnu.org; Fri, 03 Apr 2009 10:48:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LpkhF-00076A-4x for grub-devel@gnu.org; Fri, 03 Apr 2009 10:48:45 -0400 Received: from [199.232.76.173] (port=35202 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpkhE-000767-UH for grub-devel@gnu.org; Fri, 03 Apr 2009 10:48:40 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:34126) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LpkhE-0000zo-Ab for grub-devel@gnu.org; Fri, 03 Apr 2009 10:48:40 -0400 Received: by fxm10 with SMTP id 10so1016786fxm.42 for ; Fri, 03 Apr 2009 07:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type; bh=uwCjnM5yOLnNmDzimv7MmrTxP9Y6pxj1bdOc5N3Mgbo=; b=nmyraJIBrsVh9hhOD6vFxsp4w2xifkGF5jpdKfs7KfXBXR96K/uqiNyCfjUjyVJbqr D5MKxYjsPWPf7tpToEBcZgWY5dci7XZYzWbcSHj5miY8kyDetUQVez6zbhPUEB1Gb2oT 4DUhkLDH4vV/NStJwahclZAs30AXIJiF3oGdY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; b=ej0UGQr54oF8S3+LbXAtHQ/gA4Xha5DlBOFvVmA2WJvJJZUTCwBzE+zFNChLMbJ0k7 W9sujJJuCnApDP/phzs2WfOHubp7Nm8NpUj3NkGNW65RpMNahbA9ZbTRGC4TZjWeewSH P33oBC1KBCV1aFeUMvSaFZ5FMwLgFYyE2kS3c= Received: by 10.86.53.11 with SMTP id b11mr1067980fga.60.1238770118220; Fri, 03 Apr 2009 07:48:38 -0700 (PDT) Received: from ?192.168.1.2? (5-181.3-85.cust.bluewin.ch [85.3.181.5]) by mx.google.com with ESMTPS id 4sm9070429fgg.5.2009.04.03.07.48.37 (version=SSLv3 cipher=RC4-MD5); Fri, 03 Apr 2009 07:48:37 -0700 (PDT) Message-ID: <49D621C5.10702@gmail.com> Date: Fri, 03 Apr 2009 16:48:37 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49D4B4FE.2020806@gmail.com> <49D4D023.7080902@gmail.com> <1238687734.3375.4.camel@localhost> <49D501BD.4040903@gmail.com> In-Reply-To: <49D501BD.4040903@gmail.com> Content-Type: multipart/mixed; boundary="------------000104080908090301060008" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [BUGFIX] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2009 14:48:45 -0000 This is a multi-part message in MIME format. --------------000104080908090301060008 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit rgrep revealed no use for the second kernel_elf_HEADERS, so I propose to remove it altogether Is everybody comfortable with this patch? If I hear no oppositions in couple of days I'll commit it. phcoder wrote: > Is kernel_elf_HEADERS used for anything else than symlist.c and > kernel-symlist,lst generation? > Manoel Rebelo Abranches wrote: >> symlist.c is generated by gensymlist.sh script so only the patch for >> conf/powerpc-ieee1275.rmk is really necessary. >> >> On Thu, 2009-04-02 at 16:48 +0200, phcoder wrote: >>> Bean wrote: >>>> On Thu, Apr 2, 2009 at 8:52 PM, phcoder wrote: >>>>> Hello symbols from command.h aren't exported correctly. Here's a >>>>> bugfix. It >>>>> compiles with it but I haven't checked yet if compiled binary >>>>> works. Can >>>>> someone familiar with build system have a look at this? >>>> Hi, >>>> >>>> It's a little wired, why would powerpc-ieee1275.rmk has two >>>> kernel_elf_HEADERS in the first place ? >>>> >>> I have no idea, I was hoping that someone more familiar with build >>> system could tell me why it's done so >>> > > -- Regards Vladimir 'phcoder' Serbinenko --------------000104080908090301060008 Content-Type: text/x-diff; name="ppcfix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ppcfix.diff" diff --git a/ChangeLog b/ChangeLog index 8532741..61279fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2009-04-03 Vladimir Serbinenko + + * conf/powerpc-ieee1275 (kernel_elf_HEADERS): add list.h and command.h + remove suplicate kernel_elf_HEADERS + 2009-04-01 Pavel Roskin * Makefile.in: Remove all references to MODULE_LDFLAGS, it's diff --git a/conf/powerpc-ieee1275.rmk b/conf/powerpc-ieee1275.rmk index 5aaaf56..9ba2981 100644 --- a/conf/powerpc-ieee1275.rmk +++ b/conf/powerpc-ieee1275.rmk @@ -16,7 +16,8 @@ DEFSYMFILES += kernel_syms.lst kernel_elf_HEADERS = boot.h cache.h device.h disk.h dl.h elf.h elfload.h \ env.h err.h file.h fs.h kernel.h misc.h mm.h net.h parser.h rescue.h \ symbol.h term.h time.h types.h powerpc/libgcc.h loader.h partition.h \ - pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h + pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h list.h \ + command.h symlist.c: $(addprefix include/grub/,$(kernel_elf_HEADERS)) config.h gensymlist.sh /bin/sh gensymlist.sh $(filter %.h,$^) > $@ || (rm -f $@; exit 1) @@ -87,8 +88,6 @@ kernel_elf_SOURCES = kern/powerpc/ieee1275/startup.S kern/ieee1275/cmain.c \ kern/parser.c kern/partition.c kern/env.c kern/powerpc/dl.c \ kern/generic/millisleep.c kern/time.c \ symlist.c kern/powerpc/cache.S -kernel_elf_HEADERS = grub/powerpc/ieee1275/ieee1275.h list.h handler.h \ - command.h kernel_elf_CFLAGS = $(COMMON_CFLAGS) kernel_elf_ASFLAGS = $(COMMON_ASFLAGS) kernel_elf_LDFLAGS = $(COMMON_LDFLAGS) -static-libgcc -lgcc \ --------------000104080908090301060008--