From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lq24Q-0005jg-Fg for mharc-grub-devel@gnu.org; Sat, 04 Apr 2009 05:21:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lq24M-0005hh-W8 for grub-devel@gnu.org; Sat, 04 Apr 2009 05:21:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lq24M-0005hG-4K for grub-devel@gnu.org; Sat, 04 Apr 2009 05:21:42 -0400 Received: from [199.232.76.173] (port=35182 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lq24L-0005h9-TU for grub-devel@gnu.org; Sat, 04 Apr 2009 05:21:41 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:14751) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lq24L-0004ss-Cp for grub-devel@gnu.org; Sat, 04 Apr 2009 05:21:41 -0400 Received: by fg-out-1718.google.com with SMTP id 19so576479fgg.7 for ; Sat, 04 Apr 2009 02:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=w8QEDbh6JAJ49ibGAkjmOHumSrKTz25/EH2JAah3pZ0=; b=KuoHXXEGF9kDX2UU1JBfyMqzcdRWa5WXJk85q8D7gZHSML2fjaXLkI9Npz8vOtUCo0 +H01+SQK01TnGVGVFRgcl2w2vjYpm5Swas+gVL5slLMEXyg9RhCIMDccjUB0x9bLWxxp Yey2oRFas6/PU8Jq2bRKyRuxkHhcFYOh88Ekc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=SmSjk5irx4yI1bvGbVfQjD7yPmLsHEIEZkxwT7b8bdkgaUtSLjc6Mk4D8xYh6GKrTP tTE4epc3y2FuGikYXM9clclT5kevg9iMm5ichTi51m3MdW+w0p0dL9Ykg0wKyrAvbmpb LXrZyjhK/F85C+BWMlH0sFLSxSJB7cXvmuXHY= Received: by 10.86.1.1 with SMTP id 1mr1652404fga.0.1238836900341; Sat, 04 Apr 2009 02:21:40 -0700 (PDT) Received: from ?192.168.1.2? (5-181.3-85.cust.bluewin.ch [85.3.181.5]) by mx.google.com with ESMTPS id e11sm4790298fga.15.2009.04.04.02.21.39 (version=SSLv3 cipher=RC4-MD5); Sat, 04 Apr 2009 02:21:39 -0700 (PDT) Message-ID: <49D726A4.9040207@gmail.com> Date: Sat, 04 Apr 2009 11:21:40 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49AAB6E6.2080805@gmail.com> <20090313191030.GB17068@thorin> <49BC4D2C.7010804@gmail.com> In-Reply-To: <49BC4D2C.7010804@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] FAT, UFS and mtime X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2009 09:21:43 -0000 Can someone review this patch? phcoder wrote: > mtime part > 2009-03-15 Vladimir Serbinenko > > Support for mtime and further expandability of dir command > > * include/grub/lib/datetime.h: moved to ... > * include/grub/datetime.h: ... moved here and added > declaration of grub_unixtime2datetime. All users updated > * include/grub/fs.h: new syntax for dir and mtime functionin > struct grub_fs > * include/grub/fshelp.h: new declarations of GRUB_FSHELP_TYPE_MASK > and GRUB_FSHELP_FLAGS_MASK > * commands/ls.c (grub_ls_list_files): Write mtime in long format > * fs/ext2.c (grub_ext2_dir): use new dir syntax and supply mtime > (grub_ext2_mtime): new function > * fs/hfsplus.c (grub_hfsplus_dir): use new dir syntax and supply mtime > (grub_hfsplus_mtime): new function > * fs/ufs.c (GRUB_UFS_ATTR_TYPE): new definition > (GRUB_UFS_ATTR_FILE): likewise > (GRUB_UFS_ATTR_LNK): likewise > (struct grub_ufs_sblock): new fields mtime > (grub_ufs_read_inode): new parameter to read inode to a separate buffer > all users updated > (grub_ufs_dir): mtime support > (grub_ufs_mtime): new function > * fs/affs.c (grub_affs_dir): use new dir syntax > * fs/afs.c (grub_afs_dir): likewise > * fs/cpio.c (grub_cpio_dir): likewise > * fs/fat.c (grub_fat_find_dir): likewise > * fs/hfs.c (grub_hfs_dir): likewise > * fs/iso9660.c (grub_iso9660_dir): likewise > * fs/jfs.c (grub_jfs_dir): likewise > * fs/minix.c (grub_minix_dir): likewise > * fs/ntfs.c (grub_ntfs_dir): likewise > * fs/reiserfs.c (grub_reiserfs_dir): likewise > * fs/sfs.c (grub_sfs_dir): likewise > * fs/xfs.c (grub_xfs_dir): likewise > * util/hostfs.c (grub_hostfs_dir): likewise > * lib/datetime.c: moved to ... > * normal/datetime.c: ... moved here > (grub_unixtime2datetime): new function > * kern/rescue.c (grub_rescue_print_files): use new dir syntax > * normal/completition.c (iterate_dir): use new dir syntax > * normal/misc.c (grub_normal_print_device_info): tell the > last modification time of a volume > * kern/fs.c (grub_fs_probe): updated dummy function to use new syntax > * conf/i386-coreboot.rmk: added normal/datetime.c to grub-emu > and normal.mod. Removed lib/datetime.c from datetime.mod > * conf/i386-efi.rmk: likewise > * conf/i386-ieee1275.rmk: likewise > * conf/i386-pc.rmk: likewise > * conf/powerpc-ieee1275.rmk: likewise > * conf/sparc64-ieee1275.rmk: likewise > * conf/x86_64-efi.rmk: likewise > > > Robert Millan wrote: >> On Sun, Mar 01, 2009 at 05:25:10PM +0100, phcoder wrote: >>> Hello all. It seems that gcc has trouble with -m32 when structure is >>> passed as argument. So I replaced that part by a pointer. Also I >>> made some improvements to ufs code to support solaris branch of ufs. >>> I tested it also with freebsd and netbsd's branch and it works fine >>> on it too. >>> As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a >>> patch with all 3 features. If it's really necessary I can split them >>> but it requires a lot of unnecessary work >> >> Please do. It is definitely confusing to review patches that merge >> unrelated things. >> >> Also, please don't include the changelog entry in your patch, since those >> break too easily. Just paste it at the top of your mail. >> > > -- Regards Vladimir 'phcoder' Serbinenko