From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH] nfs-utils: fix AC_CHECK_FUNC calls in configure.ac Date: Sat, 04 Apr 2009 07:53:12 -0400 Message-ID: <49D74A28.1010905@RedHat.com> References: <20090316185007.13728.1047.stgit@ingres.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: jlayton@redhat.com, linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39626 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbZDDL4E (ORCPT ); Sat, 4 Apr 2009 07:56:04 -0400 In-Reply-To: <20090316185007.13728.1047.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: Chuck Lever wrote: > From: Jeff Layton > > AC_CHECK_FUNC and AC_CHECK_FUNCS take 3 args. Any ones beyond that are > ignored. In several places, we're passing the "action-if-not-found" in > as the 4th arg so it's being ignored. > > Signed-off-by: Jeff Layton > Signed-off-by: Chuck Lever > --- > > Steve- > > Thanks for committing the other patches. Here's one more nit that Jeff > found recently. > > aclocal/ipv6.m4 | 2 +- > configure.ac | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/aclocal/ipv6.m4 b/aclocal/ipv6.m4 > index 0564b3e..ba9dcc2 100644 > --- a/aclocal/ipv6.m4 > +++ b/aclocal/ipv6.m4 > @@ -15,7 +15,7 @@ AC_DEFUN([AC_IPV6], [ > fi > > dnl IPv6-enabled networking functions required for IPv6 > - AC_CHECK_FUNCS([getnameinfo bindresvport_sa], , , > + AC_CHECK_FUNCS([getnameinfo bindresvport_sa], , > [AC_MSG_ERROR([Missing functions needed for IPv6.])]) > > dnl Need to detect presence of IPv6 networking at run time via > diff --git a/configure.ac b/configure.ac > index e34b7e2..f942238 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -185,13 +185,13 @@ AC_CHECK_FUNC([connect], , > [AC_CHECK_LIB([socket], [connect], [LIBSOCKET="-lsocket"], > [AC_MSG_ERROR([Function 'socket' not found.])], [$LIBNSL])]) > > -AC_CHECK_FUNC([getaddrinfo], , , > +AC_CHECK_FUNC([getaddrinfo], , > [AC_MSG_ERROR([Function 'getaddrinfo' not found.])]) > > -AC_CHECK_FUNC([getrpcbynumber], , , > +AC_CHECK_FUNC([getrpcbynumber], , > [AC_MSG_ERROR([Function 'getrpcbynumber' not found.])]) > > -AC_CHECK_FUNC([getservbyname], , , > +AC_CHECK_FUNC([getservbyname], , > [AC_MSG_ERROR([Function 'getservbyname' not found.])]) > > AC_CHECK_LIB([crypt], [crypt], [LIBCRYPT="-lcrypt"]) > Committed.. steved