From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: Beagle: Set pinmux conditionally for Rev C boards
Date: Sun, 05 Apr 2009 14:22:39 +0200 [thread overview]
Message-ID: <49D8A28F.8020009@googlemail.com> (raw)
In-Reply-To: <20090405105921.GB11028@game.jcrosoft.org>
Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:46 Sun 05 Apr , Dirk Behme wrote:
>> The Beagle Rev C boards pull UART2 from an alternate set of balls.
>>
>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>> ---
>>
>> board/omap3/beagle/beagle.c | 4 ++++
>> board/omap3/beagle/beagle.h | 25 +++++++++++++++++--------
>> 2 files changed, 21 insertions(+), 8 deletions(-)
>>
>> Index: u-boot-main/board/omap3/beagle/beagle.c
>> ===================================================================
>> --- u-boot-main.orig/board/omap3/beagle/beagle.c
>> +++ u-boot-main/board/omap3/beagle/beagle.c
>> @@ -130,4 +130,8 @@ int misc_init_r(void)
>> void set_muxconf_regs(void)
>> {
>> MUX_BEAGLE();
>> +
>> + if(beagle_revision_c) {
> please add a space between the if and '('
>> + MUX_BEAGLE_C();
>> + }
>> }
>> Index: u-boot-main/board/omap3/beagle/beagle.h
>> ===================================================================
>> --- u-boot-main.orig/board/omap3/beagle/beagle.h
>> +++ u-boot-main/board/omap3/beagle/beagle.h
>> @@ -214,14 +214,14 @@ const omap3_sysinfo sysinfo = {
>> MUX_VAL(CP(MMC2_DAT6), (IEN | PTU | EN | M4)) /*GPIO_138*/\
>> MUX_VAL(CP(MMC2_DAT7), (IEN | PTU | EN | M4)) /*GPIO_139*/\
>> /*Bluetooth*/\
>> - MUX_VAL(CP(MCBSP3_DX), (IDIS | PTD | DIS | M4)) /*GPIO_140*/\
>> - MUX_VAL(CP(MCBSP3_DR), (IDIS | PTD | DIS | M4)) /*GPIO_142*/\
>> - MUX_VAL(CP(MCBSP3_CLKX), (IDIS | PTD | DIS | M4)) /*GPIO_141*/\
>> - MUX_VAL(CP(MCBSP3_FSX), (IDIS | PTD | DIS | M4)) /*GPIO_143*/\
> <snip>
>> +#define MUX_BEAGLE_C() \
>> + MUX_VAL(CP(MCBSP3_DX), (IDIS | PTD | DIS | M4)) /*GPIO_140*/\
>> + MUX_VAL(CP(MCBSP3_DR), (IDIS | PTD | DIS | M4)) /*GPIO_142*/\
>> + MUX_VAL(CP(MCBSP3_CLKX), (IDIS | PTD | DIS | M4)) /*GPIO_141*/\
>> + MUX_VAL(CP(UART2_CTS), (IEN | PTU | EN | M0)) /*UART2_CTS*/\
>> + MUX_VAL(CP(UART2_RTS), (IDIS | PTD | DIS | M0)) /*UART2_RTS*/\
>> + MUX_VAL(CP(UART2_TX), (IDIS | PTD | DIS | M0)) /*UART2_TX*/
> please wait Tom Rix gpio patch move to this API
We are dealing with PinMux here, not with how GPIOs are
accessed/controlled. These are two different things we talk about [1].
Dirk
[1] http://lists.denx.de/pipermail/u-boot/2009-April/050234.html
prev parent reply other threads:[~2009-04-05 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 6:46 [U-Boot] [PATCH] OMAP3: Beagle: Set pinmux conditionally for Rev C boards Dirk Behme
2009-04-05 10:59 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-05 12:22 ` Dirk Behme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D8A28F.8020009@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.