From mboxrd@z Thu Jan  1 00:00:00 1970
From: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
Subject: [PATCH] usbback: fix invalid urb->interval for
 highspeed interrupt endpoint
Date: Mon, 06 Apr 2009 16:56:45 +0900
Message-ID: <49D9B5BD.5090903@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------070409040907030509000009"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------070409040907030509000009
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit

Hi,

Current usbback fails to submit the interrupt urb for high-speed
endpoints. This patch fixes this issue.

usb_fill_int_urb() is a helper function to initialize a interrupt urb,
and sets the usb->interval value as follows,

void usb_fill_int_urb(struct urb *urb, ..., int interval)
{

	...

	if (dev->speed == USB_SPEED_HIGH)
		urb->interval = 1 << (interval - 1);
	else
		urb->interval = interval;

	...
}

The interval value that usbback got from the RING_REQ is already
modified to an exponent of two.

So, usbback must not initialize a interrupt urb with double-modified
interval value.


Signed-off-by: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>

--------------070409040907030509000009
Content-Type: text/plain;
 name="usbback_interrupt_urb_interval_fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
	filename="usbback_interrupt_urb_interval_fix.patch"

ZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3VzYmJhY2svdXNiYmFjay5jIGIvZHJpdmVycy94
ZW4vdXNiYmFjay91c2JiYWNrLmMKLS0tIGEvZHJpdmVycy94ZW4vdXNiYmFjay91c2JiYWNr
LmMKKysrIGIvZHJpdmVycy94ZW4vdXNiYmFjay91c2JiYWNrLmMKQEAgLTQ3MCw2ICs0NzAs
MTggQEAgc3RhdGljIHZvaWQgdXNiYmtfaW5pdF91cmIodXNiaWZfcmVxdWVzdAogCQkJCXBl
bmRpbmdfcmVxLT5idWZmZXIsIHJlcS0+YnVmZmVyX2xlbmd0aCwKIAkJCQl1c2Jia191cmJf
Y29tcGxldGUsCiAJCQkJcGVuZGluZ19yZXEsIHJlcS0+dS5pbnRyLmludGVydmFsKTsKKwkJ
LyoKKwkJICogaGlnaCBzcGVlZCBpbnRlcnJ1cHQgZW5kcG9pbnRzIHVzZSBhIGxvZ2FyaXRo
bWljIGVuY29kaW5nIG9mCisJCSAqIHRoZSBlbmRwb2ludCBpbnRlcnZhbCwgYW5kIHVzYl9m
aWxsX2ludF91cmIoKSBpbml0aWFsaXplcyBhCisJCSAqIGludGVycnVwdCB1cmIgd2l0aCB0
aGUgZW5jb2RlZCBpbnRlcnZhbCB2YWx1ZS4KKwkJICoKKwkJICogcmVxLT51LmludHIuaW50
ZXJ2YWwgaXMgdGhlIGludGVydmFsIHZhbHVlIHRoYXQgYWxyZWFkeQorCQkgKiBlbmNvZGVk
IGluIHRoZSBmcm9udGVuZCBwYXJ0LCBhbmQgdGhlIGFib3ZlIHVzYl9maWxsX2ludF91cmIo
KQorCQkgKiBpbml0aWFsaXplcyB0aGUgdXJiLT5pbnRlcnZhbCB3aXRoIGRvdWJsZSBlbmNv
ZGVkIHZhbHVlLgorCQkgKgorCQkgKiBzbywgc2ltcGx5IG92ZXJ3cml0ZSB0aGUgdXJiLT5p
bnRlcnZhbCB3aXRoIG9yaWdpbmFsIHZhbHVlLgorCQkgKi8KKwkJdXJiLT5pbnRlcnZhbCA9
IHJlcS0+dS5pbnRyLmludGVydmFsOwogCQl1cmItPnRyYW5zZmVyX2ZsYWdzID0gcmVxLT50
cmFuc2Zlcl9mbGFnczsKIAogCQlicmVhazsK
--------------070409040907030509000009
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------070409040907030509000009--