From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Daniel_Gl=F6ckner?= Subject: Re: [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface Date: Mon, 06 Apr 2009 11:48:49 +0200 Message-ID: <49D9D001.7070901@emlix.com> References: <1238266022-27893-1-git-send-email-dg@emlix.com> <20090404143741.GA6474@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mx1.emlix.com (mx1.emlix.com [193.175.82.87]) by alsa0.perex.cz (Postfix) with ESMTP id EEA66243C9 for ; Mon, 6 Apr 2009 11:48:49 +0200 (CEST) In-Reply-To: <20090404143741.GA6474@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 04/04/2009 04:37 PM, Mark Brown wrote: > This all looks good - the only concern I have is the issue with the > polarity of the clock signals I mentioned in reply to the machine > driver. The code in the machine driver does make it look like the I2S > driver is using the opposite polarity to that expected. You are right, this is wrong. Patch follows Daniel -- = Dipl.-Math. Daniel Gl=F6ckner, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 G=F6ttingen, Germany Gesch=E4ftsf=FChrung: Dr. Uwe Kracke, Dr. Cord Seele, Ust-IdNr.: DE 205 198= 055 Sitz der Gesellschaft: G=F6ttingen, Amtsgericht G=F6ttingen HR B 3160 emlix - your embedded linux partner