From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LqlVV-0001jc-TI for mharc-grub-devel@gnu.org; Mon, 06 Apr 2009 05:52:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqlVT-0001hp-NZ for grub-devel@gnu.org; Mon, 06 Apr 2009 05:52:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqlVO-0001dp-To for grub-devel@gnu.org; Mon, 06 Apr 2009 05:52:43 -0400 Received: from [199.232.76.173] (port=43350 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqlVO-0001dY-G7 for grub-devel@gnu.org; Mon, 06 Apr 2009 05:52:38 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:50392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LqlVN-00028t-U9 for grub-devel@gnu.org; Mon, 06 Apr 2009 05:52:38 -0400 Received: by fxm10 with SMTP id 10so2014158fxm.42 for ; Mon, 06 Apr 2009 02:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=dqJompiDrtNVkGvELubCTrwdvH4fP9bexUzqNfxlD4Q=; b=T0JppOjeFBQZS0nGErbAIOr+vWswqGk4jA0qvVKl+pGmj+AaRJEM6CC7zJi+v/dGsl CAKB0xnud0KMz56PWNmmkhZb/tMGnJ4urkUccO4hoginmgLVhB9RX6RjlWHbFxrkjihK xEIrpQO2po1XePjt+O0ZFGnSGVhUfskLIrNPE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=lo+5Kd3DOiXJJhlH8u/6jv4ZSwkiZJip5OVUpTfab26sz+LO0mqiBHiw8okVPZozW+ 5N88sLKhIg2eDu/RqaGMlFFqvZogPvhYtjXwHNXFd/vHVIW4zKhaqk/AKYF5U/Sj39WE Tk/2+8aICARKJmXz5PU0WVgL+feldBLzAjt8o= Received: by 10.86.94.11 with SMTP id r11mr2964751fgb.11.1239011556882; Mon, 06 Apr 2009 02:52:36 -0700 (PDT) Received: from ?82.130.80.49? (hg-public-dock-49-dhcp.ethz.ch [82.130.80.49]) by mx.google.com with ESMTPS id e20sm11989766fga.29.2009.04.06.02.52.35 (version=SSLv3 cipher=RC4-MD5); Mon, 06 Apr 2009 02:52:36 -0700 (PDT) Message-ID: <49D9D0E6.5090706@gmail.com> Date: Mon, 06 Apr 2009 11:52:38 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49AEEF72.5050000@gmail.com> <49C3EF85.5080908@gmail.com> <49D726DF.4010601@gmail.com> <200904052348.15540.okuji@enbug.org> In-Reply-To: <200904052348.15540.okuji@enbug.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] parttool X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2009 09:52:44 -0000 Fixed & commited. My next patch will be to add automatic module loading in parttool Yoshinori K. Okuji wrote: > On Saturday 04 April 2009 18:22:39 phcoder wrote: >> Can someone review this patch? > > Only some style should be corrected. For example: > > +#ifndef GRUB_UTIL > + if (!parts) > + grub_dl_unref (mymod); > +#endif > > Our convention is to put a space between "!" and "parts", so this should be: > > +#ifndef GRUB_UTIL > + if (! parts) > + grub_dl_unref (mymod); > +#endif > > Also, the ChangeLog should state what variables are affected explicitly. For > example: > > * conf/common.rmk: Added parttool.mod and pcpart.mod > > Instead, you should say: > > * conf/common.rmk (parttool_mod_SOURCES): New variable. > (parttool_mod_CFLAGS): Likewise. > (parttool_mod_LDFLAGS): Likewise. > ...and so on... > > The code itself looks good, so you can check it in, once you correct the > styles. > > Regards, > Okuji > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko