Re: [PATCH 06/07] sata_mv: cosmetic renames

[Mark Lord <liml@rtr.ca>]

Jeff Garzik wrote:
> Mark Lord wrote:
>> Add _OFS suffix to more of the register offset names,
>> for consistency with the rest of the driver.
>>
>> Also tag the defines for LTMODE and PHY_MODE4 to note
>> that read-after-write is necessary when updating those regs.
>>
>> No code changes here.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>>
>> --- old/drivers/ata/sata_mv.c    2009-04-06 14:20:53.000000000 -0400
>> +++ new/drivers/ata/sata_mv.c    2009-04-06 15:00:16.000000000 -0400
>> @@ -272,17 +272,17 @@
>>     SATA_FIS_IRQ_CAUSE_OFS    = 0x364,
>>     SATA_FIS_IRQ_AN        = (1 << 9),    /* async notification */
>>
>> -    LTMODE_OFS        = 0x30c,
>> +    LTMODE_OFS        = 0x30c,    /* requires read-after-write */
>>     LTMODE_BIT8        = (1 << 8),    /* unknown, but necessary */
>>
>> -    PHY_MODE3        = 0x310,
>> -    PHY_MODE4        = 0x314,
>> +    PHY_MODE2_OFS        = 0x330,
>> +    PHY_MODE3_OFS        = 0x310,
>> +    PHY_MODE4_OFS        = 0x314,    /* requires read-after-write */
>>     PHY_MODE4_CFG_MASK    = 0x00000003,    /* phy internal config 
>> field */
>>     PHY_MODE4_CFG_VALUE    = 0x00000001,    /* phy internal config 
>> field */
>>     PHY_MODE4_RSVD_ZEROS    = 0x5de3fffa,    /* Gen2e always write 
>> zeros */
>>     PHY_MODE4_RSVD_ONES    = 0x00000005,    /* Gen2e always write ones */
> 
> _OFS suffix is redundant, and not often used in other Linux drivers.
..

Yeah, I agree it's kinda fugly, too.
But that's what was there from the earlier maintainers
(Brett and yourself, I guess), so for now I'm just keeping it consistent.

I might now try patch 08 follow-up to rename all of that stuff,
if you're happy with the series thus far.  Plan is to drop the _OFS stuff,
and also make a bunch of the register prefixes more consistent as well.

Currenly, some regs use MV_ whereas others don't, and some have SATA_
at the start but related registers don't.

Any preferences there?  It's all the same to me.

Cheers