From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: Dustin Harrison <d.harrison@sutus.com>,
Sagar Borikar <sagar.borikar@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: ata_check_status_mmio exception kernel panic
Date: Mon, 06 Apr 2009 22:59:36 -0400 [thread overview]
Message-ID: <49DAC198.1090708@pobox.com> (raw)
In-Reply-To: <49D6E90C.5030109@kernel.org>
Tejun Heo wrote:
> Can you please move the logic to sil_freeze() and see whether it
> works? The freeze handler is supposed to put the controller into idle
> (or at least not-crazy) state, so things like this fit there.
ata_qc_complete() is called before ->freeze(), and ata_qc_complete()
needs taskfile access to fill the result TF.
I thought about ->pre_freeze(), but now I wonder if we shouldn't just
call __ata_port_freeze() before ata_port_abort(), in ata_port_freeze()?
Jeff
next prev parent reply other threads:[~2009-04-07 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 3:06 ata_check_status_mmio exception kernel panic Sagar Borikar
2009-04-01 3:08 ` Sagar Borikar
2009-04-01 3:37 ` Tejun Heo
2009-04-03 17:56 ` Dustin Harrison
2009-04-04 4:58 ` Tejun Heo
2009-04-07 2:59 ` Jeff Garzik [this message]
2009-04-04 16:00 ` Alan Cox
2009-04-07 3:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DAC198.1090708@pobox.com \
--to=jgarzik@pobox.com \
--cc=d.harrison@sutus.com \
--cc=linux-ide@vger.kernel.org \
--cc=sagar.borikar@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.