All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: do_domctl and EAGAIN
Date: Tue, 07 Apr 2009 09:04:58 +0200	[thread overview]
Message-ID: <49DAFB1A.3030405@ts.fujitsu.com> (raw)

Hi,

certain domctl hypercalls (and possibly others as well) might fail with errno
EAGAIN. This case seems to be tested only in very few places, e.g. in
xc_domain_destroy.

Is there any reason why this case isn't handled in do_domctl?
Shouldn't EINTR be handled as well?

The other solution would be to have two versions of do_domctl, one of them
looping in case of EAGAIN or EINTR.

I suspect this lack of errno-testing could lead to very sporadic failures...


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@ts.fujitsu.com
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

             reply	other threads:[~2009-04-07  7:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  7:04 Juergen Gross [this message]
2009-04-07  7:20 ` do_domctl and EAGAIN Keir Fraser
2009-04-07  7:41   ` Juergen Gross
2009-04-07  7:47     ` Keir Fraser
2009-04-07  8:36       ` Juergen Gross
2009-04-07  8:49         ` Keir Fraser
2009-04-07  8:03     ` Keir Fraser
2009-04-07  8:19       ` Juergen Gross
2009-04-07  8:53         ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DAFB1A.3030405@ts.fujitsu.com \
    --to=juergen.gross@ts.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.