From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lr5mu-0003wt-C9 for mharc-grub-devel@gnu.org; Tue, 07 Apr 2009 03:32:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lr5mr-0003vG-D6 for grub-devel@gnu.org; Tue, 07 Apr 2009 03:32:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lr5mm-0003rC-K7 for grub-devel@gnu.org; Tue, 07 Apr 2009 03:32:01 -0400 Received: from [199.232.76.173] (port=49936 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lr5mm-0003qz-Co for grub-devel@gnu.org; Tue, 07 Apr 2009 03:31:56 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:61129) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lr5mm-0002w5-0f for grub-devel@gnu.org; Tue, 07 Apr 2009 03:31:56 -0400 Received: by fxm10 with SMTP id 10so2500482fxm.42 for ; Tue, 07 Apr 2009 00:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=hQ27Mh97+2/+0rcZOc2RT7uFm3Oem49rah3sXJuHPMY=; b=bQkju7Z1ieR7CGZzMDUsVECLZ58NkFe8weeml8gRiKsnutHBe8IcC3GR1vfHJrI6SU Uu0LP0dYHH28XtGswE6oYMnvGhzxlAbs4n0HD+rnUUiauRp2DMlmFe68KCe1SE9UTAh4 8JRmLHhKGq0gFa3GosBUABoRr+t/fpYo02WTw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=g3wvLL6rpftjzOFzdpf6H83CMUWd9xohfKpcvzXEPKe0wOOW7/bsWrhaGpoHoXO2tC pQKGIMkkbSN0LAy6L0mrk8Y9Dufou298JfzG36rIThVrxAg6Qmfy0Xa9lUULc+x60Ema jZoVgCGuVhDDDyf5ipP1qEtk1HcfO3lHkVp/Y= Received: by 10.204.62.68 with SMTP id w4mr2452891bkh.122.1239089514862; Tue, 07 Apr 2009 00:31:54 -0700 (PDT) Received: from ?82.130.83.110? (hpx-public-dock-110-dhcp.ethz.ch [82.130.83.110]) by mx.google.com with ESMTPS id 31sm1974353fkt.2.2009.04.07.00.31.54 (version=SSLv3 cipher=RC4-MD5); Tue, 07 Apr 2009 00:31:54 -0700 (PDT) Message-ID: <49DB016D.1070000@gmail.com> Date: Tue, 07 Apr 2009 09:31:57 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <1239032043.8986.27.camel@mj> <200904070931.09559.okuji@enbug.org> <1239065374.15621.202.camel@mj> In-Reply-To: <1239065374.15621.202.camel@mj> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Video mode fixes in linux loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 07:32:01 -0000 Does it actually work? I don't see the code which either handles GRUB_LINUX_VID_MODE_ASK or passes it to the kernel. Also it looks like vga= parameter is parsed by grub and grub passes only video mode values as resolution and color depth. Wouldn't it be better to move to a more modern video mode specification method? As gfxpayload variable previously discussed on that list Pavel Roskin wrote: > On Tue, 2009-04-07 at 09:31 +0900, Yoshinori K. Okuji wrote: >>> + free_pages(); >> Please insert a space before the parenthesis. > > Done. > >> This is not due to you, but the comment above is not synchronized with the >> code apparently. Can you fix it? > > Fixed and committed. > -- Regards Vladimir 'phcoder' Serbinenko