All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-eh: call freeze hook before port abort
Date: Tue, 07 Apr 2009 15:58:08 -0700	[thread overview]
Message-ID: <49DBDA80.2020204@gmail.com> (raw)
In-Reply-To: <49DBC7F1.3040801@garzik.org>

Hello,

Jeff Garzik wrote:
> This patch looks like it might work for !PMP setups, but I am not so
> sure about PMP.

Looks good to me too.  PMP shouldn't make any difference if the port
is being frozen.  The new behavior is more correct.

> Any comments?  This should help begin addressing the problem where
> hardware needs the DMA engine turned off before accessing the
> taskfile registers -- something needed for ata_port_abort() via
> ata_qc_complete().

Yeah, if this can work around the reported problem, I think this is
the correct way to fix it.

Thanks.

-- 
tejun

      reply	other threads:[~2009-04-07 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 21:38 [PATCH] libata-eh: call freeze hook before port abort Jeff Garzik
2009-04-07 22:58 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DBDA80.2020204@gmail.com \
    --to=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.