From: Claudio Scordino <claudio@evidence.eu.com>
To: Jesper Nilsson <Jesper.Nilsson@axis.com>, starvik@axis.com
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Hinko Kocevar <hinko.kocevar@cetrtapot.si>,
Janez Cufer <janez.cufer@cetrtapot.si>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
dev-etrax@axis.com, adobriyan@gmail.com
Subject: [PATCH] Fix broken compilation of Cris serial driver
Date: Wed, 08 Apr 2009 12:07:16 +0200 [thread overview]
Message-ID: <49DC7754.4030404@evidence.eu.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
Hi,
compilation of cris serial driver on 2.6.30-rc1 is broken since
commit number 0f043a81ebe84be3576667f04fdda481609e3816 removed the
read_proc field from the tty_driver structure.
The patch in attachment may fix the problem. Please check it very
carefully: I don't have hardware to make any test.
Regards,
Claudio
[-- Attachment #2: 0001-Fix-remove-read_proc-field-from-cris-serial-driver.patch --]
[-- Type: text/x-diff, Size: 1305 bytes --]
From: Claudio Scordino <claudio@evidence.eu.com>
Commit number 0f043a81ebe84be3576667f04fdda481609e3816 removed the read_proc
field from the tty_driver structure.
This broke cris serial driver compilation.
Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
---
drivers/serial/crisv10.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/crisv10.c b/drivers/serial/crisv10.c
index 7ba7d70..a331e40 100644
--- a/drivers/serial/crisv10.c
+++ b/drivers/serial/crisv10.c
@@ -27,6 +27,7 @@ static char *serial_version = "$Revision: 1.25 $";
#include <linux/kernel.h>
#include <linux/mutex.h>
#include <linux/bitops.h>
+#include <linux/proc_fs.h>
#include <asm/io.h>
#include <asm/irq.h>
@@ -4425,7 +4426,6 @@ static const struct tty_operations rs_ops = {
.break_ctl = rs_break,
.send_xchar = rs_send_xchar,
.wait_until_sent = rs_wait_until_sent,
- .read_proc = rs_read_proc,
.tiocmget = rs_tiocmget,
.tiocmset = rs_tiocmset
};
@@ -4490,6 +4490,7 @@ rs_init(void)
if (tty_register_driver(driver))
panic("Couldn't register serial driver\n");
/* do some initializing for the separate ports */
+ driver->proc_entry->read_proc = rs_read_proc;
for (i = 0, info = rs_table; i < NR_PORTS; i++,info++) {
if (info->enabled) {
--
1.5.4.3
next reply other threads:[~2009-04-08 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 10:07 Claudio Scordino [this message]
2009-04-08 10:12 ` [PATCH] Fix broken compilation of Cris serial driver Mikael Starvik
2009-04-08 10:45 ` Claudio Scordino
2009-04-08 10:57 ` Jesper Nilsson
2009-04-08 12:51 ` Alexey Dobriyan
2009-04-08 14:00 ` Jesper Nilsson
2009-04-08 15:52 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DC7754.4030404@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=Jesper.Nilsson@axis.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dev-etrax@axis.com \
--cc=hinko.kocevar@cetrtapot.si \
--cc=janez.cufer@cetrtapot.si \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.