All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH v2] Enable use of cached metadata for pvs & pvdisplay
Date: Wed, 08 Apr 2009 12:50:47 +0200	[thread overview]
Message-ID: <49DC8187.1070104@redhat.com> (raw)
In-Reply-To: <49DC3F7C.1030006@redhat.com>

Takahiro Yasui wrote:
>> @@ -778,12 +785,19 @@ int process_each_pv(struct cmd_context *cmd, int argc, char **argv,
>>  				if (ret > ret_max)
>>  					ret_max = ret;
>>  				if (sigint_caught())
>> -					return ret_max;
>> +					goto bad;
> 
> In the above line, "goto bad" is typo of "goto out"?

hm. you are right, I thought that signal interruption should return ECMD_FAIL but apparently
reporting code do not use that.

We should probably define something like ECMD_INTERRUPTED and use that... but it is unrelated problem.


If Alasdair acks that, I fix it in real commit.

Milan



      reply	other threads:[~2009-04-08 10:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 11:26 [PATCH] Enable use of cached metadata for pvs & pvdisplay Milan Broz
2009-04-07  3:04 ` Takahiro Yasui
2009-04-07 11:04 ` [PATCH v2] " Milan Broz
2009-04-08  6:09   ` Takahiro Yasui
2009-04-08 10:50     ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DC8187.1070104@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.