From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 4/6] vg mempool: fix archiver code
Date: Wed, 08 Apr 2009 13:15:09 +0200 [thread overview]
Message-ID: <49DC873D.6010301@redhat.com> (raw)
In-Reply-To: <87skkk9hlk.fsf@eriador.mornfall.net>
Petr Rockai wrote:
> Milan Broz <mbroz@redhat.com> writes:
>> + vg_release(vg);
> Check. Actually looks much more robust. While looking through the code, I have
> noticed that there is likely still a leak in there though, since
> create_text_context will call dm_pool_alloc/dm_pool_strdup a few times. If I
> understand dm_pool_free correctly, this only frees the part of the pool from
> the "vg" pointer till end of the pool, so the leak has been there even
> before. You might want to fix that by calling dm_pool_free(cmd->mem, context)
> besides the vg_release. (This all needs double-checking though.)
There are more such places in code for sure, some structures are even allocated
from global mempool still. (I have at least one more patch in my queue).
But this can be fixed in subsequent patches - my main intention was to put
vg_release to correct places in code (otherwise it will leak the whole pool).
Milan
prev parent reply other threads:[~2009-04-08 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 8:32 [PATCH 4/6] vg mempool: fix archiver code Milan Broz
2009-04-07 23:20 ` Petr Rockai
2009-04-08 11:15 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DC873D.6010301@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.