From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lrd2n-0007E0-E3 for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:02:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lrd2i-000752-5O for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:02:40 -0400 Received: from [199.232.76.173] (port=53260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrd2h-00074l-Qi for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:02:35 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:37283) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lrd2h-00007q-8D for qemu-devel@nongnu.org; Wed, 08 Apr 2009 15:02:35 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e7.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n38IqerO000807 for ; Wed, 8 Apr 2009 14:52:40 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n38J2UaZ171190 for ; Wed, 8 Apr 2009 15:02:30 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n38J0o2T014805 for ; Wed, 8 Apr 2009 15:00:51 -0400 Message-ID: <49DCF4C1.7090303@us.ibm.com> Date: Wed, 08 Apr 2009 14:02:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/6] Introduce monitor 'wait' command (v2) References: <1239215702-23818-1-git-send-email-aliguori@us.ibm.com> <1239215702-23818-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: libvir-list@redhat.com, Jan Kiszka , qemu-devel@nongnu.org, Hollis Blanchard Blue Swirl wrote: > On 4/8/09, Anthony Liguori wrote: > >> The wait command will pause the monitor the command was issued in until a new >> event becomes available. Events are queued if there isn't a waiter present. >> The wait command completes after a single event is available. >> > > >> + if (!w->polling) >> + monitor_resume(w->mon); >> > > CODING_STYLE, chapter 4: > "Every indented statement is braced; even if the block contains just one > statement." > > ;-) > That's going to take me some time to get used to :-) I've been trying to stick with it... Regards, Anthony Liguori -- Regards, Anthony Liguori