From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LrdVf-0006n4-S4 for mharc-grub-devel@gnu.org; Wed, 08 Apr 2009 15:32:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrdVe-0006mr-CI for grub-devel@gnu.org; Wed, 08 Apr 2009 15:32:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrdVd-0006mf-LE for grub-devel@gnu.org; Wed, 08 Apr 2009 15:32:29 -0400 Received: from [199.232.76.173] (port=37632 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrdVd-0006mc-H1 for grub-devel@gnu.org; Wed, 08 Apr 2009 15:32:29 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:21145) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LrdVd-0004sm-2g for grub-devel@gnu.org; Wed, 08 Apr 2009 15:32:29 -0400 Received: by fg-out-1718.google.com with SMTP id 19so90230fgg.7 for ; Wed, 08 Apr 2009 12:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=pOgC2MZHtmQN3+E1/+wqqXa9T+/mv+T3NUPPwT9qKZk=; b=QmE7FFTs5LYLpSmeVvJgMoGOAo6Q7IDc0BM8UeXkF4nHYUXlyysRr5URZ6uQgSQZHg qa5Xcill8VRlj0Gch9uxB9L2Ijl41Hu2WUyHCkwuhvYbSmOOzk+PYZwttJLNLYdVDe4g QIaHaY9l4yYXuh/uGn9pLb2VVmZiwKJnqO7iE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=bg53L4PBRVRuOPex2N881FG4cCiUrVYUY2M7MZ7PCra3t6Ir5k87yO7rSi66lu/8xA 1ZvryOFPZvHyN+6TWCDHPv5Vg321A7E4Y8w7N0n9CdYP4koPdIqKq2DzoCeIe5JccAFc P8UWq9njg8GXur39n75gAHk2hzWm1zszwKJLE= Received: by 10.86.61.13 with SMTP id j13mr1301282fga.68.1239219148258; Wed, 08 Apr 2009 12:32:28 -0700 (PDT) Received: from ?192.168.1.2? (174-112.78-83.cust.bluewin.ch [83.78.112.174]) by mx.google.com with ESMTPS id 3sm10616907fge.14.2009.04.08.12.32.27 (version=SSLv3 cipher=RC4-MD5); Wed, 08 Apr 2009 12:32:27 -0700 (PDT) Message-ID: <49DCFBCF.2080004@gmail.com> Date: Wed, 08 Apr 2009 21:32:31 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49DCF533.6050809@linux.vnet.ibm.com> <1239218477.4827.18.camel@fz.local> In-Reply-To: <1239218477.4827.18.camel@fz.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] add clear screen command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 19:32:30 -0000 Perhaps putting it into normal.mod instead of separate module is a good idea Felix Zielcke wrote: > Am Mittwoch, den 08.04.2009, 16:04 -0300 schrieb Carlos Roberto do > Nascimento Costa: >> Hello, >> >> This simple patch will add a new command to clear the terminal screen. Very >> useful on the command-line. >> > > Hello, > > + * Copyright (C) 2003,2007 Free Software Foundation, Inc. > + * Copyright (C) 2003 NIIBE Yutaka > > This should be just `Copyright (C) 2009 Free Software Foundation, Inc.', > because it's a new file from this year. > > + (void)mod; /* To stop warning. */ > + cmd = grub_register_command ("clear", grub_cmd_clear, > + 0, "Clear the terminal screen."); > > I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'. > And please write a ChangeLog entry. > -- Regards Vladimir 'phcoder' Serbinenko