From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Date: Wed, 08 Apr 2009 21:55:48 +0200 Message-ID: <49DD0144.7050902@grandegger.com> References: <20090407082052.477328750@denx.de> <53B42D49-C040-442E-8448-7BC3190220A5@kernel.crashing.org> <49DC515F.3040100@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kumar Gala Cc: Linux/PPC Development , devicetree-discuss , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks List-Id: linux-i2c@vger.kernel.org Kumar Gala wrote: > > On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: > >>> So I'm a bit concerned with the output we now get: >>> >>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) >>> >>> why 0? is that right? >> >> This is the backward compatibility mode using hard-coded FDR values. The >> output is missleading, I agree. >> >> Wolfgang. > > Can the output be fixed. 0 Hz seemed bad to me. Of course. No info message will be printed for the legacy case like it was with the old driver version. I just realized a bug in the MPC52xx part. Will send patches tomorrow, after some more thorough testing. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <49DD0144.7050902@grandegger.com> Date: Wed, 08 Apr 2009 21:55:48 +0200 From: Wolfgang Grandegger MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable References: <20090407082052.477328750@denx.de> <53B42D49-C040-442E-8448-7BC3190220A5@kernel.crashing.org> <49DC515F.3040100@grandegger.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: Linux/PPC Development , devicetree-discuss , linux-i2c@vger.kernel.org, Ben Dooks List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > > On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: > >>> So I'm a bit concerned with the output we now get: >>> >>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) >>> >>> why 0? is that right? >> >> This is the backward compatibility mode using hard-coded FDR values. The >> output is missleading, I agree. >> >> Wolfgang. > > Can the output be fixed. 0 Hz seemed bad to me. Of course. No info message will be printed for the legacy case like it was with the old driver version. I just realized a bug in the MPC52xx part. Will send patches tomorrow, after some more thorough testing. Wolfgang.