From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LrgMJ-0000qd-JD for mharc-grub-devel@gnu.org; Wed, 08 Apr 2009 18:35:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrgMH-0000qN-9N for grub-devel@gnu.org; Wed, 08 Apr 2009 18:35:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrgMC-0000q1-K0 for grub-devel@gnu.org; Wed, 08 Apr 2009 18:35:00 -0400 Received: from [199.232.76.173] (port=46920 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrgMC-0000py-Ef for grub-devel@gnu.org; Wed, 08 Apr 2009 18:34:56 -0400 Received: from e24smtp05.br.ibm.com ([32.104.18.26]:44547) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrgMB-000082-Qr for grub-devel@gnu.org; Wed, 08 Apr 2009 18:34:56 -0400 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp05.br.ibm.com (8.13.1/8.13.1) with ESMTP id n38MUmpD026924 for ; Wed, 8 Apr 2009 19:30:48 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n38MZC7x2113572 for ; Wed, 8 Apr 2009 19:35:12 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n38MYprx014451 for ; Wed, 8 Apr 2009 19:34:51 -0300 Received: from [9.8.15.136] ([9.8.15.136]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n38MYo3F014444 for ; Wed, 8 Apr 2009 19:34:51 -0300 Message-ID: <49DD268A.6030108@linux.vnet.ibm.com> Date: Wed, 08 Apr 2009 19:34:50 -0300 From: Carlos Roberto do Nascimento Costa User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49DCF533.6050809@linux.vnet.ibm.com> <1239218477.4827.18.camel@fz.local> In-Reply-To: <1239218477.4827.18.camel@fz.local> Content-Type: multipart/mixed; boundary="------------060107060205040709040003" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] add clear screen command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 22:35:01 -0000 This is a multi-part message in MIME format. --------------060107060205040709040003 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Felix, thank you for reviewing this patch. Felix Zielcke wrote: > Hello, > > + * Copyright (C) 2003,2007 Free Software Foundation, Inc. > + * Copyright (C) 2003 NIIBE Yutaka > > This should be just `Copyright (C) 2009 Free Software Foundation, Inc.', > because it's a new file from this year. My bad, I'm sorry. Now is fixed, see new [clear2.patch] file attached. > + (void)mod; /* To stop warning. */ > + cmd = grub_register_command ("clear", grub_cmd_clear, > + 0, "Clear the terminal screen."); > > I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'. Yes, you are right. grub_register_command isn't the correct function to register a command and grub_register_extcmd is the new way. However, there are still modules need to be fixed, right?! I'll write another e-mail about it soon. > And please write a ChangeLog entry. > My bad. Now fixed too. Best Regards, -- Carlos Roberto do Nascimento Costa E-mails: crncosta@linux.vnet.ibm.com IBM - Linux Technology Center Brasil --------------060107060205040709040003 Content-Type: text/x-patch; name="clear2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="clear2.patch" Index: ChangeLog =================================================================== --- ChangeLog (revision 2073) +++ ChangeLog (working copy) @@ -1,3 +1,11 @@ +2009-04-08 Carlos Costa + + * commands/clear.c: new file. + * conf/common.rmk (pkglib_MODULES): Added clear.mod. + (clear_mod_SOURCES): new variable. + (clear_mod_CFLAGS): likewise. + (clear_mod_LDFLAGS): likewise. + 2009-04-08 Felix Zielcke * disk/lvm.c (grub_lvm_scan_device): Add a missing NULL check. Index: commands/clear.c =================================================================== --- commands/clear.c (revision 0) +++ commands/clear.c (revision 0) @@ -0,0 +1,50 @@ +/* clear.c - command to clear the terminal screen. */ +/* + * GRUB -- GRand Unified Bootloader + * Copyright (C) 2009 Free Software Foundation, Inc. + * + * GRUB is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * GRUB is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with GRUB. If not, see . + */ + +#include +#include +#include +#include +#include +#include + + +static grub_err_t +grub_cmd_clear (struct grub_extcmd *cmd __attribute__ ((unused)), + int argc __attribute__ ((unused)), + char **args __attribute__ ((unused))) +{ + grub_cls (); + return 0; +} + +static grub_command_t cmd; + +GRUB_MOD_INIT(clear) +{ + (void)mod; /* To stop warning. */ + cmd = grub_register_extcmd ("clear", grub_cmd_clear, + GRUB_COMMAND_FLAG_CMDLINE,"clear", + "Clear the terminal screen.",0); +} + +GRUB_MOD_FINI(clear) +{ + grub_unregister_extcmd (cmd); +} Index: conf/common.rmk =================================================================== --- conf/common.rmk (revision 2073) +++ conf/common.rmk (working copy) @@ -332,7 +332,7 @@ # Commands. pkglib_MODULES += minicmd.mod extcmd.mod hello.mod handler.mod \ - ls.mod cmp.mod cat.mod help.mod search.mod \ + ls.mod cmp.mod cat.mod help.mod search.mod clear.mod \ loopback.mod fs_uuid.mod configfile.mod echo.mod \ terminfo.mod test.mod blocklist.mod hexdump.mod \ read.mod sleep.mod loadenv.mod crc.mod parttool.mod pcpart.mod @@ -382,6 +382,11 @@ cat_mod_CFLAGS = $(COMMON_CFLAGS) cat_mod_LDFLAGS = $(COMMON_LDFLAGS) +# For clear.mod +clear_mod_SOURCES = commands/clear.c +clear_mod_CFLAGS = $(COMMON_CFLAGS) +clear_mod_LDFLAGS = $(COMMON_LDFLAGS) + # For echo.mod echo_mod_SOURCES = commands/echo.c echo_mod_CFLAGS = $(COMMON_CFLAGS) --------------060107060205040709040003--