From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LrgWA-0004Qc-GQ for mharc-grub-devel@gnu.org; Wed, 08 Apr 2009 18:45:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrgW8-0004QH-J8 for grub-devel@gnu.org; Wed, 08 Apr 2009 18:45:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrgW7-0004Pu-2P for grub-devel@gnu.org; Wed, 08 Apr 2009 18:45:11 -0400 Received: from [199.232.76.173] (port=60328 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrgW6-0004Pn-TT for grub-devel@gnu.org; Wed, 08 Apr 2009 18:45:10 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:47831) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LrgW6-00018g-IL for grub-devel@gnu.org; Wed, 08 Apr 2009 18:45:10 -0400 Received: by fg-out-1718.google.com with SMTP id 19so110599fgg.7 for ; Wed, 08 Apr 2009 15:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=4jYfBbcxdFRNxsHCSyMWyzHmLxtoJlutwTdrC1s1Yj4=; b=UzFA6xiff5SL3kxvn3My3RsZUpaRkS2OqQ8LqGHozhylOwN3dey37ilodKaaHOprMr gh9B1wDOrSYiosOR0I7hHdJmg9zdHaayf19kXOvnWKAxn1j6wjOft88gYKSgkehoasr/ ZQ6Oznagd4RftXEfTJaKmKTS42r/EwLQh3n3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=GZMYXJpmRfEu9G0QNu/44dT1gWgUpAeBdXLrcKIfCk75GV7bI3avYsL7/xuqJDKlrg VOkfTXI183brZvn0AYKyKtORgfEf74qVY4h9IDFHaI6xo7a5rWMghgHxm7yzKvFynJB2 wOs70NvfpOOLrXaJPboibwxeWTZ/OOgMQjbOg= Received: by 10.86.59.2 with SMTP id h2mr1445891fga.30.1239230709178; Wed, 08 Apr 2009 15:45:09 -0700 (PDT) Received: from ?192.168.1.2? (174-112.78-83.cust.bluewin.ch [83.78.112.174]) by mx.google.com with ESMTPS id d4sm10829119fga.13.2009.04.08.15.45.08 (version=SSLv3 cipher=RC4-MD5); Wed, 08 Apr 2009 15:45:08 -0700 (PDT) Message-ID: <49DD28F8.6020507@gmail.com> Date: Thu, 09 Apr 2009 00:45:12 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49DCF533.6050809@linux.vnet.ibm.com> <1239218477.4827.18.camel@fz.local> <49DD268A.6030108@linux.vnet.ibm.com> In-Reply-To: <49DD268A.6030108@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] add clear screen command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 22:45:13 -0000 Carlos Roberto do Nascimento Costa wrote: >> + (void)mod; /* To stop warning. */ >> + cmd = grub_register_command ("clear", grub_cmd_clear, >> + 0, "Clear the terminal screen."); >> >> I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'. > > Yes, you are right. grub_register_command isn't the correct function to register > a command and grub_register_extcmd is the new way. However, there are still > modules need to be fixed, right?! I'll write another e-mail about it soon. > Your declaration is correct > > ------------------------------------------------------------------------ > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko