diff for duplicates of <49DDC35B.1010606@fastmail.fm> diff --git a/a/1.txt b/N1/1.txt index 2910e1e..35fa208 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,8 +20,8 @@ Jack Stone wrote: > } > > ret = -ENOMEM; -> - if ((raw_buf = (char *)amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) = -> + if ((raw_buf = amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) = +> - if ((raw_buf = (char *)amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) == +> + if ((raw_buf = amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) == > NULL) { > printk("fd: cannot get chip mem buffer\n"); > goto out_memregion; @@ -36,7 +36,7 @@ Jack Stone wrote: > - c = (CommandList_struct *) pci_alloc_consistent(h->pdev, > + c = pci_alloc_consistent(h->pdev, > sizeof(CommandList_struct), &cmd_dma_handle); -> if (c = NULL) +> if (c == NULL) > return NULL; > @@ -460,8 +460,7 @@ static CommandList_struct *cmd_alloc(ctlr_info_t *h, int get_from_pool) > @@ -47,9 +47,10 @@ Jack Stone wrote: > + c->err_info = pci_alloc_consistent(h->pdev, sizeof(ErrorInfo_struct), > &err_dma_handle); > -> if (c->err_info = NULL) { +> if (c->err_info == NULL) { > @@ -3773,12 +3772,10 @@ static int __devinit cciss_init_one(struct pci_dev *pdev, -> hba[i]->cmd_pool_bits > kmalloc(DIV_ROUND_UP(hba[i]->nr_cmds, BITS_PER_LONG) +> hba[i]->cmd_pool_bits = +> kmalloc(DIV_ROUND_UP(hba[i]->nr_cmds, BITS_PER_LONG) > * sizeof(unsigned long), GFP_KERNEL); > - hba[i]->cmd_pool = (CommandList_struct *) > - pci_alloc_consistent(hba[i]->pdev, @@ -61,7 +62,7 @@ Jack Stone wrote: > + hba[i]->errinfo_pool = pci_alloc_consistent(hba[i]->pdev, > hba[i]->nr_cmds * sizeof(ErrorInfo_struct), > &(hba[i]->errinfo_pool_dhandle)); -> if ((hba[i]->cmd_pool_bits = NULL) +> if ((hba[i]->cmd_pool_bits == NULL) > diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c > index a3fd87b..1e997b2 100644 > --- a/drivers/block/cciss_scsi.c @@ -74,7 +75,7 @@ Jack Stone wrote: > - pci_alloc_consistent(hba[ctlr]->pdev, size, &stk->cmd_pool_handle); > + stk->pool = pci_alloc_consistent(hba[ctlr]->pdev, size, &stk->cmd_pool_handle); > -> if (stk->pool = NULL) { +> if (stk->pool == NULL) { > printk("stk->pool is null\n"); > diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c > index ca268ca..207fbb6 100644 @@ -87,7 +88,7 @@ Jack Stone wrote: > - c = (cmdlist_t*)pci_alloc_consistent(h->pci_dev, > + c = pci_alloc_consistent(h->pci_dev, > sizeof(cmdlist_t), &cmd_dhandle); -> if(c=NULL) +> if(c==NULL) > return NULL; > diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c > index ff0448e..48c8bb4 100644 @@ -113,7 +114,7 @@ Jack Stone wrote: > - bevent = (struct vioblocklpevent *) > - vio_get_event_buffer(viomajorsubtype_blockio); > + bevent = vio_get_event_buffer(viomajorsubtype_blockio); -> if (bevent = NULL) { +> if (bevent == NULL) { > printk(VIOD_KERN_WARNING > "error allocating disk event buffer\n"); > diff --git a/a/content_digest b/N1/content_digest index f5f0a02..c248259 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\01239189748-11703-6-git-send-email-jwjstone@fastmail.fm\0" "From\0Jack Stone <jwjstone@fastmail.fm>\0" "Subject\0Re: [PATCH 05/56] block: Remove void casts\0" - "Date\0Thu, 09 Apr 2009 09:43:55 +0000\0" + "Date\0Thu, 09 Apr 2009 10:43:55 +0100\0" "To\0linux-kernel@vger.kernel.org\0" "Cc\0jeff@garzik.org" kernel-janitors@vger.kernel.org @@ -35,8 +35,8 @@ "> \t}\n" "> \n" "> \tret = -ENOMEM;\n" - "> -\tif ((raw_buf = (char *)amiga_chip_alloc (RAW_BUF_SIZE, \"Floppy\")) =\n" - "> +\tif ((raw_buf = amiga_chip_alloc (RAW_BUF_SIZE, \"Floppy\")) =\n" + "> -\tif ((raw_buf = (char *)amiga_chip_alloc (RAW_BUF_SIZE, \"Floppy\")) ==\n" + "> +\tif ((raw_buf = amiga_chip_alloc (RAW_BUF_SIZE, \"Floppy\")) ==\n" "> \t NULL) {\n" "> \t\tprintk(\"fd: cannot get chip mem buffer\\n\");\n" "> \t\tgoto out_memregion;\n" @@ -51,7 +51,7 @@ "> -\t\tc = (CommandList_struct *) pci_alloc_consistent(h->pdev,\n" "> +\t\tc = pci_alloc_consistent(h->pdev,\n" "> \t\t\tsizeof(CommandList_struct), &cmd_dma_handle);\n" - "> \t\tif (c = NULL)\n" + "> \t\tif (c == NULL)\n" "> \t\t\treturn NULL;\n" "> @@ -460,8 +460,7 @@ static CommandList_struct *cmd_alloc(ctlr_info_t *h, int get_from_pool)\n" "> \n" @@ -62,9 +62,10 @@ "> +\t\tc->err_info = pci_alloc_consistent(h->pdev, sizeof(ErrorInfo_struct),\n" "> \t\t\t &err_dma_handle);\n" "> \n" - "> \t\tif (c->err_info = NULL) {\n" + "> \t\tif (c->err_info == NULL) {\n" "> @@ -3773,12 +3772,10 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,\n" - "> \thba[i]->cmd_pool_bits > \t kmalloc(DIV_ROUND_UP(hba[i]->nr_cmds, BITS_PER_LONG)\n" + "> \thba[i]->cmd_pool_bits =\n" + "> \t kmalloc(DIV_ROUND_UP(hba[i]->nr_cmds, BITS_PER_LONG)\n" "> \t\t\t* sizeof(unsigned long), GFP_KERNEL);\n" "> -\thba[i]->cmd_pool = (CommandList_struct *)\n" "> -\t pci_alloc_consistent(hba[i]->pdev,\n" @@ -76,7 +77,7 @@ "> +\thba[i]->errinfo_pool = pci_alloc_consistent(hba[i]->pdev,\n" "> \t\t hba[i]->nr_cmds * sizeof(ErrorInfo_struct),\n" "> \t\t &(hba[i]->errinfo_pool_dhandle));\n" - "> \tif ((hba[i]->cmd_pool_bits = NULL)\n" + "> \tif ((hba[i]->cmd_pool_bits == NULL)\n" "> diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c\n" "> index a3fd87b..1e997b2 100644\n" "> --- a/drivers/block/cciss_scsi.c\n" @@ -89,7 +90,7 @@ "> -\t\tpci_alloc_consistent(hba[ctlr]->pdev, size, &stk->cmd_pool_handle);\n" "> +\tstk->pool = pci_alloc_consistent(hba[ctlr]->pdev, size, &stk->cmd_pool_handle);\n" "> \n" - "> \tif (stk->pool = NULL) {\n" + "> \tif (stk->pool == NULL) {\n" "> \t\tprintk(\"stk->pool is null\\n\");\n" "> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c\n" "> index ca268ca..207fbb6 100644\n" @@ -102,7 +103,7 @@ "> -\t\tc = (cmdlist_t*)pci_alloc_consistent(h->pci_dev, \n" "> +\t\tc = pci_alloc_consistent(h->pci_dev, \n" "> \t\t\tsizeof(cmdlist_t), &cmd_dhandle);\n" - "> \t\tif(c=NULL)\n" + "> \t\tif(c==NULL)\n" "> \t\t\treturn NULL;\n" "> diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c\n" "> index ff0448e..48c8bb4 100644\n" @@ -128,9 +129,9 @@ "> -\t\tbevent = (struct vioblocklpevent *)\n" "> -\t\t\tvio_get_event_buffer(viomajorsubtype_blockio);\n" "> +\t\tbevent = vio_get_event_buffer(viomajorsubtype_blockio);\n" - "> \t\tif (bevent = NULL) {\n" + "> \t\tif (bevent == NULL) {\n" "> \t\t\tprintk(VIOD_KERN_WARNING\n" "> \t\t\t \"error allocating disk event buffer\\n\");\n" > -6b61f91559ce66ffe8941fa37f6d7c37e39ecda2352fcf5aa2bad2d228b7ca59 +f3f2d9c207b2246e768e83998093088f0c0421014ee14f8283e275449111dedb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.