diff for duplicates of <49DDCB66.8050408@fastmail.fm> diff --git a/a/1.txt b/N1/1.txt index 6a27d78..cb74b0f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ Jack Stone wrote: > case SNDCTL_COPR_LOAD: > - buf = (copr_buffer *) vmalloc(sizeof(copr_buffer)); > + buf = vmalloc(sizeof(copr_buffer)); -> if (buf = NULL) +> if (buf == NULL) > return -ENOSPC; > if (copy_from_user(buf, arg, sizeof(copr_buffer))) { > @@ -871,7 +871,7 @@ static int pss_coproc_ioctl(void *dev_info, unsigned int cmd, void __user *arg, @@ -42,7 +42,7 @@ Jack Stone wrote: > case SNDCTL_COPR_SENDMSG: > - mbuf = (copr_msg *)vmalloc(sizeof(copr_msg)); > + mbuf = vmalloc(sizeof(copr_msg)); -> if (mbuf = NULL) +> if (mbuf == NULL) > return -ENOSPC; > if (copy_from_user(mbuf, arg, sizeof(copr_msg))) { > @@ -895,7 +895,7 @@ static int pss_coproc_ioctl(void *dev_info, unsigned int cmd, void __user *arg, @@ -51,7 +51,7 @@ Jack Stone wrote: > err = 0; > - mbuf = (copr_msg *)vmalloc(sizeof(copr_msg)); > + mbuf = vmalloc(sizeof(copr_msg)); -> if (mbuf = NULL) +> if (mbuf == NULL) > return -ENOSPC; > data = (unsigned short *)mbuf->data; > diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c @@ -64,14 +64,14 @@ Jack Stone wrote: > return; > - queue = (unsigned char *)vmalloc(SEQ_MAX_QUEUE * EV_SZ); > + queue = vmalloc(SEQ_MAX_QUEUE * EV_SZ); -> if (queue = NULL) +> if (queue == NULL) > { > printk(KERN_ERR "sequencer: Can't allocate memory for sequencer output queue\n"); > return; > } > - iqueue = (unsigned char *)vmalloc(SEQ_MAX_QUEUE * IEV_SZ); > + iqueue = vmalloc(SEQ_MAX_QUEUE * IEV_SZ); -> if (iqueue = NULL) +> if (iqueue == NULL) > { > printk(KERN_ERR "sequencer: Can't allocate memory for sequencer input queue\n"); > diff --git a/sound/oss/sscape.c b/sound/oss/sscape.c @@ -84,7 +84,7 @@ Jack Stone wrote: > case SNDCTL_COPR_LOAD: > - buf = (copr_buffer *) vmalloc(sizeof(copr_buffer)); > + buf = vmalloc(sizeof(copr_buffer)); -> if (buf = NULL) +> if (buf == NULL) > return -ENOSPC; > if (copy_from_user(buf, arg, sizeof(copr_buffer))) > diff --git a/a/content_digest b/N1/content_digest index 61e0130..8f805de 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,7 +16,7 @@ "ref\01239189748-11703-38-git-send-email-jwjstone@fastmail.fm\0" "From\0Jack Stone <jwjstone@fastmail.fm>\0" "Subject\0Re: [PATCH 37/56] oss: Remove void casts\0" - "Date\0Thu, 09 Apr 2009 10:18:14 +0000\0" + "Date\0Thu, 09 Apr 2009 11:18:14 +0100\0" "To\0linux-kernel@vger.kernel.org\0" "Cc\0jeff@garzik.org" kernel-janitors@vger.kernel.org @@ -58,7 +58,7 @@ "> \t\tcase SNDCTL_COPR_LOAD:\n" "> -\t\t\tbuf = (copr_buffer *) vmalloc(sizeof(copr_buffer));\n" "> +\t\t\tbuf = vmalloc(sizeof(copr_buffer));\n" - "> \t\t\tif (buf = NULL)\n" + "> \t\t\tif (buf == NULL)\n" "> \t\t\t\treturn -ENOSPC;\n" "> \t\t\tif (copy_from_user(buf, arg, sizeof(copr_buffer))) {\n" "> @@ -871,7 +871,7 @@ static int pss_coproc_ioctl(void *dev_info, unsigned int cmd, void __user *arg,\n" @@ -67,7 +67,7 @@ "> \t\tcase SNDCTL_COPR_SENDMSG:\n" "> -\t\t\tmbuf = (copr_msg *)vmalloc(sizeof(copr_msg));\n" "> +\t\t\tmbuf = vmalloc(sizeof(copr_msg));\n" - "> \t\t\tif (mbuf = NULL)\n" + "> \t\t\tif (mbuf == NULL)\n" "> \t\t\t\treturn -ENOSPC;\n" "> \t\t\tif (copy_from_user(mbuf, arg, sizeof(copr_msg))) {\n" "> @@ -895,7 +895,7 @@ static int pss_coproc_ioctl(void *dev_info, unsigned int cmd, void __user *arg,\n" @@ -76,7 +76,7 @@ "> \t\t\terr = 0;\n" "> -\t\t\tmbuf = (copr_msg *)vmalloc(sizeof(copr_msg));\n" "> +\t\t\tmbuf = vmalloc(sizeof(copr_msg));\n" - "> \t\t\tif (mbuf = NULL)\n" + "> \t\t\tif (mbuf == NULL)\n" "> \t\t\t\treturn -ENOSPC;\n" "> \t\t\tdata = (unsigned short *)mbuf->data;\n" "> diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c\n" @@ -89,14 +89,14 @@ "> \t\treturn;\n" "> -\tqueue = (unsigned char *)vmalloc(SEQ_MAX_QUEUE * EV_SZ);\n" "> +\tqueue = vmalloc(SEQ_MAX_QUEUE * EV_SZ);\n" - "> \tif (queue = NULL)\n" + "> \tif (queue == NULL)\n" "> \t{\n" "> \t\tprintk(KERN_ERR \"sequencer: Can't allocate memory for sequencer output queue\\n\");\n" "> \t\treturn;\n" "> \t}\n" "> -\tiqueue = (unsigned char *)vmalloc(SEQ_MAX_QUEUE * IEV_SZ);\n" "> +\tiqueue = vmalloc(SEQ_MAX_QUEUE * IEV_SZ);\n" - "> \tif (iqueue = NULL)\n" + "> \tif (iqueue == NULL)\n" "> \t{\n" "> \t\tprintk(KERN_ERR \"sequencer: Can't allocate memory for sequencer input queue\\n\");\n" "> diff --git a/sound/oss/sscape.c b/sound/oss/sscape.c\n" @@ -109,9 +109,9 @@ "> \t\tcase SNDCTL_COPR_LOAD:\n" "> -\t\t\tbuf = (copr_buffer *) vmalloc(sizeof(copr_buffer));\n" "> +\t\t\tbuf = vmalloc(sizeof(copr_buffer));\n" - "> \t\t\tif (buf = NULL)\n" + "> \t\t\tif (buf == NULL)\n" "> \t\t\t\treturn -ENOSPC;\n" "> \t\t\tif (copy_from_user(buf, arg, sizeof(copr_buffer))) \n" > -04ddc00600f2cda84e3c63e017e8a8d1eea1f5a240dfe3b8f2b9461d7d620108 +a9f7bc6cb5ce736dc8fab4fdb1851e52c49c39dd92c5f0a4d9ec1061e62d7976
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.