From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LruYJ-0007lj-3U for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 09:44:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LruYH-0007kH-56 for grub-devel@gnu.org; Thu, 09 Apr 2009 09:44:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LruYC-0007fT-7z for grub-devel@gnu.org; Thu, 09 Apr 2009 09:44:20 -0400 Received: from [199.232.76.173] (port=52262 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LruYC-0007fE-2s for grub-devel@gnu.org; Thu, 09 Apr 2009 09:44:16 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:56007) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LruYB-0001I5-Lb for grub-devel@gnu.org; Thu, 09 Apr 2009 09:44:15 -0400 Received: by fxm10 with SMTP id 10so648662fxm.42 for ; Thu, 09 Apr 2009 06:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=OLhFIfUn2Km0JYNLJln9gelGDBmg3srMsXObsJ6GXCI=; b=a7SA1+X7cTzs5TyetAc2ecPi9QKl7wpvHxHZYY3dXKOkZrpPdOv+ppJrYyCrS0jLkX TIKTDp34kXWqxWyTPwDcOCB4kLZNU4F+PnRdN4zMne8VbKXVSfcOG51P5eMlZIirGbbV gePD+uUk6cLrnPQJON8HqNBwY6Jg3s8dGKSMs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=gARCKFkWkgxdodurtrgSQKihAtuc2LGQsEJSfzje3OSHc1HJWdopR99MwxKV9WuJ9G NsKvGi9RlL08PLCBjuuKZzX54trKzob6yJIuWSf9EJcEnSu0r3QO8BbFnEeEa3OSyHER E/GHTNKg87+YOodUzL/YG+V6jef11FR62Byvs= Received: by 10.102.218.8 with SMTP id q8mr328347mug.45.1239284652058; Thu, 09 Apr 2009 06:44:12 -0700 (PDT) Received: from ?82.130.80.253? (hg-public-dock-253-dhcp.ethz.ch [82.130.80.253]) by mx.google.com with ESMTPS id 14sm475338muo.20.2009.04.09.06.44.11 (version=SSLv3 cipher=RC4-MD5); Thu, 09 Apr 2009 06:44:11 -0700 (PDT) Message-ID: <49DDFBAA.6010309@gmail.com> Date: Thu, 09 Apr 2009 15:44:10 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49DCF533.6050809@linux.vnet.ibm.com> <1239218477.4827.18.camel@fz.local> <49DCFBCF.2080004@gmail.com> <49DD2A87.5090609@linux.vnet.ibm.com> In-Reply-To: <49DD2A87.5090609@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] add clear screen command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 13:44:21 -0000 Carlos Roberto do Nascimento Costa wrote: > Hello phcoder. thank you for reviewing this patch. You're welcome > > phcoder wrote: >> Perhaps putting it into normal.mod instead of separate module is a good >> idea > > When I did this patch, I was thinking: clear is a command like ls, lspci, > reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at commands/ > dir and follows the same ideas behind other commands. > > Is there any reason to not follows this idea? > With your patch the created elf contains much more overhead then code. While it isn't really a problem it's still a thing about which some thinking is needed > Best regards, > -- Regards Vladimir 'phcoder' Serbinenko