From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LrvNh-0006GI-1q
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:37:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LrvNc-0006Ds-Gd
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:37:28 -0400
Received: from [199.232.76.173] (port=45747 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LrvNc-0006De-4c
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:37:24 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45469)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LrvNb-0000b8-MZ
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 10:37:23 -0400
Message-ID: <49DE081D.1030702@redhat.com>
Date: Thu, 09 Apr 2009 17:37:17 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2)
References: <1239215702-23818-1-git-send-email-aliguori@us.ibm.com>
	<49DDAF9F.7040400@redhat.com> <49DDF807.1050707@us.ibm.com>
	<49DDFAD5.7060808@redhat.com> <49DDFC5C.4080504@us.ibm.com>
	<49DE0042.9050103@redhat.com> <49DE0271.8090103@us.ibm.com>
	<49DE05F2.5060304@redhat.com> <49DE0673.3070501@us.ibm.com>
In-Reply-To: <49DE0673.3070501@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: libvir-list@redhat.com, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, Hollis Blanchard <hollisb@us.ibm.com>

Anthony Liguori wrote:
> Avi Kivity wrote:
>>
>> (qemu) notify enospace on
>> (qemu) notify vnc-connect on
>> (qemu)
>> notification: vnc connection ...
>> (qemu) notify migration-completion on
>> (qemu) migrate -d ...
>> notification: enospc on ide0-0
>> (qemu) migrate_cancel
>> notification: migration cancelled
>> (qemu) migrate -d ...
>> (qemu)
>> notification: migration completed
>
> What are the rules for printing out 'notification'?  Do you want for 
> the end of the buffer to be '\n' or '\n(qemu )'?  If so, if I type:
>
> (qemu) f
>
> But don't hit enter, would that suppress notification?
>

I'd make everything line-oriented.  Anything from the user up to \n is 
buffered and ignored until the \n arrives.

Once the \n arrives, the command is acted upon atomically, either 
completing fully or launching an async notification.

So the rules are: whenever the monitor is idle, a notification can be 
printed out.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.