All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic.nl>
To: Eric Wong <normalperson@yhbt.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-svn: always initialize with core.autocrlf=false
Date: Thu, 09 Apr 2009 19:21:29 +0200	[thread overview]
Message-ID: <49DE2E99.9060804@pelagic.nl> (raw)
In-Reply-To: <20090409165920.GA6311@dcvr.yhbt.net>

Eric Wong wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
>> It has been reported time and time again in relation to msysGit that
>> git-svn does not work well when core.autocrlf has any value other than
>> 'false'.  So let's make it so by default.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Acked-by: Eric Wong <normalperson@yhbt.net>
> 
>> ---
>>  git-svn.perl |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 8be6be0..d4e8fc8 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -325,6 +325,7 @@ sub do_git_init_db {
>>  		command_noisy(@init_db);
>>  		$_repository = Git->repository(Repository => ".git");
>>  	}
>> +	command_noisy('config', 'core.autocrlf', 'false');
>>  	my $set;
>>  	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
>>  	foreach my $i (keys %icv) {
>> -- 
>> 1.6.2.1.613.g25746
> 
funny that this kind of seems to get through while my suggestion (and
proff by tests) to do the same for the cvs-import stuff resulted in
hefty discussions and no consensus on what to do, the result of which is
to do nothing. i guess i couldn't make myself clear enough?

  reply	other threads:[~2009-04-09 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1239276588u.git.johannes.schindelin@gmx.de>
2009-04-09 11:29 ` [PATCH] git-svn: always initialize with core.autocrlf=false Johannes Schindelin
2009-04-09 16:59   ` Eric Wong
2009-04-09 17:21     ` Ferry Huberts (Pelagic) [this message]
2009-04-09 18:30       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DE2E99.9060804@pelagic.nl \
    --to=ferry.huberts@pelagic.nl \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.