From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Sant Subject: Re: [CFQ/OOPS] rb_erase with April 9 next tree Date: Fri, 10 Apr 2009 12:10:02 +0530 Message-ID: <49DEE9C2.1040500@in.ibm.com> References: <20090409163305.8c7a0371.sfr@canb.auug.org.au> <49DE1969.1000709@in.ibm.com> <20090409172918.GE5178@kernel.dk> <20090409174420.GG5178@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from e23smtp02.au.ibm.com ([202.81.31.144]:58340 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbZDJGkI (ORCPT ); Fri, 10 Apr 2009 02:40:08 -0400 In-Reply-To: <20090409174420.GG5178@kernel.dk> Sender: linux-next-owner@vger.kernel.org List-ID: To: Jens Axboe Cc: linuxppc-dev@ozlabs.org, Stephen Rothwell , linux-next@vger.kernel.org, LKML Jens Axboe wrote: > > Can you see if this fixes it for you? > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > index e01b103..64de5c0 100644 > --- a/block/cfq-iosched.c > +++ b/block/cfq-iosched.c > @@ -1654,6 +1654,7 @@ retry: > } > > RB_CLEAR_NODE(&cfqq->rb_node); > + RB_CLEAR_NODE(&cfqq->p_node); > INIT_LIST_HEAD(&cfqq->fifo); > > atomic_set(&cfqq->ref, 0); > Yes. The above patch fixed this oops. Thanks Regards -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India --------------------------------- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp01.au.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 77B16DDF8E for ; Fri, 10 Apr 2009 16:40:07 +1000 (EST) Received: from d23relay02.au.ibm.com (d23relay02.au.ibm.com [202.81.31.244]) by e23smtp01.au.ibm.com (8.13.1/8.13.1) with ESMTP id n3A6dYxu002139 for ; Fri, 10 Apr 2009 16:39:34 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay02.au.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3A6e6oZ1081448 for ; Fri, 10 Apr 2009 16:40:06 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3A6e6k0028154 for ; Fri, 10 Apr 2009 16:40:06 +1000 Message-ID: <49DEE9C2.1040500@in.ibm.com> Date: Fri, 10 Apr 2009 12:10:02 +0530 From: Sachin Sant MIME-Version: 1.0 To: Jens Axboe Subject: Re: [CFQ/OOPS] rb_erase with April 9 next tree References: <20090409163305.8c7a0371.sfr@canb.auug.org.au> <49DE1969.1000709@in.ibm.com> <20090409172918.GE5178@kernel.dk> <20090409174420.GG5178@kernel.dk> In-Reply-To: <20090409174420.GG5178@kernel.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, LKML , Stephen Rothwell List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jens Axboe wrote: > > Can you see if this fixes it for you? > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > index e01b103..64de5c0 100644 > --- a/block/cfq-iosched.c > +++ b/block/cfq-iosched.c > @@ -1654,6 +1654,7 @@ retry: > } > > RB_CLEAR_NODE(&cfqq->rb_node); > + RB_CLEAR_NODE(&cfqq->p_node); > INIT_LIST_HEAD(&cfqq->fifo); > > atomic_set(&cfqq->ref, 0); > Yes. The above patch fixed this oops. Thanks Regards -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India ---------------------------------