From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LsQ0K-0007a8-JL for mharc-grub-devel@gnu.org; Fri, 10 Apr 2009 19:19:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsQ0I-0007ZX-CH for grub-devel@gnu.org; Fri, 10 Apr 2009 19:19:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsQ0D-0007Ye-VS for grub-devel@gnu.org; Fri, 10 Apr 2009 19:19:22 -0400 Received: from [199.232.76.173] (port=50514 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsQ0D-0007Ya-OF for grub-devel@gnu.org; Fri, 10 Apr 2009 19:19:17 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:42859) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LsQ0D-0007ek-5g for grub-devel@gnu.org; Fri, 10 Apr 2009 19:19:17 -0400 Received: by fxm10 with SMTP id 10so1359860fxm.42 for ; Fri, 10 Apr 2009 16:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=sRknCCmbAzdfj7vjY+20rmTqDokFvZmwcgxIQWWBt3M=; b=B1DElkCDkxhPawzrI9EbWrBQHZcYASXntozhGDxb2UVIRCrt4MuaHbbS4c+ULu7RUP veHfwTG7HM7ablATSouyeXqqbybhVUx1cECdP86f6I/4V9EmNBfsqKH1oe4Z/UxN1Kq4 ZMha50+fFtOEDC23kABozRPCDFoaYf7OrnJeI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=SXm4DzLWlUfUEmluz/8PE6CUlcuXFQF2z3mv+Qz8Kc1Awh2dD0Qp9a1efZ6jEURNOL j+PQ1gBC/t0QjT6kiRb5C7kzrluhXNoTcqWX/t5JhNaaoAfPYaC3K//j/G4+WU5d4yyd POPrLIKDg4G5zpFVyr7jtCiiMMAycaTDAVVL4= Received: by 10.86.53.11 with SMTP id b11mr985149fga.67.1239405556374; Fri, 10 Apr 2009 16:19:16 -0700 (PDT) Received: from ?192.168.1.25? (16-189.62-81.cust.bluewin.ch [81.62.189.16]) by mx.google.com with ESMTPS id e20sm3163139fga.24.2009.04.10.16.19.15 (version=SSLv3 cipher=RC4-MD5); Fri, 10 Apr 2009 16:19:15 -0700 (PDT) Message-ID: <49DFD3F2.6040800@gmail.com> Date: Sat, 11 Apr 2009 01:19:14 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <20081101123229.GA14438@thorin> <20081101190204.GB4639@thorin> <49109AB8.4010509@nic.fi> <20081104190751.GA25519@thorin> <49109EE7.6050406@nic.fi> <20081104193911.GA26419@thorin> <491143E2.4040705@t-online.de> <20081105094240.GA12201@thorin> In-Reply-To: <20081105094240.GA12201@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] framework for building modules externally X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2009 23:19:22 -0000 Robert Millan wrote: > On Wed, Nov 05, 2008 at 07:57:38AM +0100, Christian Franke wrote: >> Alternative: Export a symbol describing the ABI version in kernel >> ("grub_abi_3_14"). > > That requires more bytes than a 32-bit integer. You export grub_abi anyway. _3_14 is 4 bytes instead of 4 but saves. grub_abi_* can be a fictive variable by adding something like {"grub_abi_<..>", 0}, to gensymlist.sh.in > >> Access this symbol in each module (this can be hidden >> in GRUB_MOD_INIT). > > And this adds code in every module, but for non-external modules we already > have reassurance that their abi is consistent (users should never bypass > grub-install; if they do, it's likely going to break for them anyway). > > I understand there's a minor benefit for programmers of external modules, > but both things are at the expense of extra size to kernel and core.img > modules. External modules will only provide non-essential functionality, so > it's not a problem they have to check the ABI IMHO. > -- Regards Vladimir 'phcoder' Serbinenko