All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/7] tracing/filters: disallow newline as delimeter
Date: Sat, 11 Apr 2009 15:55:11 +0800	[thread overview]
Message-ID: <49E04CDF.90004@cn.fujitsu.com> (raw)
In-Reply-To: <49E04C22.4040608@cn.fujitsu.com>

I guess because user input is often ended with '\n' (like "echo xxx"),
thus '\n' is used as a delimeter besides ' ' ? But we can just strip
tailing spaces.

One of the effects of this patch, is fixing this inconsistency:

 # echo -n 'parent_comm ==' > filter
 bash: echo: write error: Invalid argument

 # echo 'parent_comm ==' > filter
 # cat filter
 parent_comm ==

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/trace/trace_events_filter.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 2bf4481..8e3a095 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -364,7 +364,9 @@ int filter_parse(char **pbuf, struct filter_pred *pred)
 	char *tmp, *tok, *val_str = NULL;
 	int tok_n = 0;
 
-	while ((tok = strsep(pbuf, " \n"))) {
+	strstrip(*pbuf);
+
+	while ((tok = strsep(pbuf, " "))) {
 		if (tok_n == 0) {
 			if (!strcmp(tok, "0")) {
 				pred->clear = 1;
-- 
1.5.4.rc3


  parent reply	other threads:[~2009-04-11  7:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-11  7:52 [PATCH 0/7] tracing: bug fixes for tracing/filters Li Zefan
2009-04-11  7:52 ` [PATCH 1/7] tracing/filters: NUL-terminate user input filter Li Zefan
2009-04-11  7:52 ` [PATCH 2/7] tracing/filters: fix NULL pointer dereference Li Zefan
2009-04-12 10:06   ` [tip:tracing/urgent] " Li Zefan
2009-04-11  7:52 ` [PATCH 3/7] tracing/filters: allow user input integer to be oct or hex Li Zefan
2009-04-12 10:06   ` [tip:tracing/urgent] " Li Zefan
2009-04-11  7:53 ` [PATCH 4/7] tracing/filters: allow user to specify a filter val to be string Li Zefan
2009-04-11 14:35   ` Frederic Weisbecker
2009-04-12 10:04     ` Ingo Molnar
2009-04-13  1:37     ` Li Zefan
2009-04-13  3:45       ` Ingo Molnar
2009-04-11  7:55 ` Li Zefan [this message]
2009-04-11  7:55 ` [PATCH 6/7] tracing/filters: return proper error code when writing filter file Li Zefan
2009-04-12 10:07   ` [tip:tracing/urgent] " Li Zefan
2009-04-11  7:55 ` [PATCH 7/7] tracing/filters: make filter preds RCU safe Li Zefan
2009-04-11  9:30 ` [PATCH 0/7] tracing: bug fixes for tracing/filters Tom Zanussi
2009-04-11 10:08   ` Li Zefan
2009-04-11 14:48   ` Frederic Weisbecker
2009-04-11 17:36     ` Paul E. McKenney
2009-04-11 17:58     ` Tom Zanussi
2009-04-12 10:02     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E04CDF.90004@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.