From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lsiaw-0001EM-0W for mharc-grub-devel@gnu.org; Sat, 11 Apr 2009 15:10:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lsiau-0001E5-E9 for grub-devel@gnu.org; Sat, 11 Apr 2009 15:10:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lsiat-0001Dt-VY for grub-devel@gnu.org; Sat, 11 Apr 2009 15:10:24 -0400 Received: from [199.232.76.173] (port=45514 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lsiat-0001Dq-SV for grub-devel@gnu.org; Sat, 11 Apr 2009 15:10:23 -0400 Received: from fg-out-1718.google.com ([72.14.220.157]:38316) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lsiat-0007g3-Bv for grub-devel@gnu.org; Sat, 11 Apr 2009 15:10:23 -0400 Received: by fg-out-1718.google.com with SMTP id 19so457617fgg.7 for ; Sat, 11 Apr 2009 12:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=4D9ubsltzM3/l2A7AZFfguvFx/a7QnCryIy2nGndTlU=; b=ufoSzjYQ5SuLmY3uxnr8C7HYg/3CBe4xIWldFgtHimTQnD+KHShMU/gwF7ONNL4q94 2zSCy1GGnxNcey9Eg0gX+aBwVunOsFAT9SARgPc3BYDYndGAfG7TkDLPOYwDHbIMAJAT D2kk3sUhKz0CLvrd6mmqNRU1b+nqxXO0jSO2o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=FADNoJCoI/9f0dF//YtJvpjC0Kl9qxiiU1ZPCTPsIoJ5N6o9wX1XQIYu15wwwCp1eL Okf26l85SJMwf/EdI9jat97GZJGS/j/cjGBCwf6iQfFAQyMy/usN/Md3ngZL2nj70L0s qfAQjg7OOyC4S4aYxNGVUgZvX4ljQMFj0rVYs= Received: by 10.86.33.10 with SMTP id g10mr3546708fgg.56.1239477022556; Sat, 11 Apr 2009 12:10:22 -0700 (PDT) Received: from ?192.168.1.25? (122-34.1-85.cust.bluewin.ch [85.1.34.122]) by mx.google.com with ESMTPS id d6sm3970484fga.12.2009.04.11.12.10.21 (version=SSLv3 cipher=RC4-MD5); Sat, 11 Apr 2009 12:10:22 -0700 (PDT) Message-ID: <49E0EB22.4070308@gmail.com> Date: Sat, 11 Apr 2009 21:10:26 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090411.010829.45951849.davem@davemloft.net> <200904111919.49761.okuji@enbug.org> <20090411.044848.183598331.davem@davemloft.net> In-Reply-To: <20090411.044848.183598331.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 19:10:24 -0000 I do not agree with having separate grub_itoa/grub_ltoa/grub_lltoa in kernel where the size is critical. We should have only lltoa and use it in all contexts. I know because of divmod64 it's slower than ltoa or itoa but it's used only for output so speed isn't so important David Miller wrote: > From: "Yoshinori K. Okuji" > Date: Sat, 11 Apr 2009 19:19:49 +0900 > >> On Saturday 11 April 2009 17:08:29 David Miller wrote: >>> The grub printf code tries to treat 'long' and 'int' the same, >>> that doesn't work on (most) 64-bit platforms. >> Right. Good finding. > > Committed. Thanks for reviewing. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko