From: Mark Lord <liml@rtr.ca>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: Saeed Bishara <saeed@marvell.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_mv: increate the IORDY timeout for the soc controllers
Date: Sun, 12 Apr 2009 10:37:48 -0400 [thread overview]
Message-ID: <49E1FCBC.5010101@rtr.ca> (raw)
In-Reply-To: <20090411160815.GA10995@deprecation.cyrius.com>
Martin Michlmayr wrote:
> From: Saeed Bishara <saeed@marvell.com>
>
> The old value (in clock cycles) is not suitable for soc devices that
> have internal clock more that 150MHz.
>
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 5315b5f..f19f2e3 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -3330,7 +3330,7 @@ static void mv_soc_reset_hc_port(struct mv_host_priv *hpriv,
> ZERO(0x024); /* respq outp */
> ZERO(0x020); /* respq inp */
> ZERO(0x02c); /* test control */
> - writel(0xbc, port_mmio + EDMA_IORDY_TMOUT);
> + writel(0x800, port_mmio + EDMA_IORDY_TMOUT);
> }
>
> #undef ZERO
..
I want to see somebody actually test/verify that
this works with PIO/MWDMA2 devices (eg. CF cards) first.
Test results?
next prev parent reply other threads:[~2009-04-12 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 16:08 [PATCH] sata_mv: increate the IORDY timeout for the soc controllers Martin Michlmayr
2009-04-12 14:37 ` Mark Lord [this message]
2009-04-13 7:13 ` saeed bishara
2009-04-13 12:49 ` Mark Lord
2009-04-13 13:11 ` saeed bishara
2009-04-13 13:50 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E1FCBC.5010101@rtr.ca \
--to=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.