From: Arjan van de Ven <arjan@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-pm@lists.linux-foundation.org, Takashi Iwai <tiwai@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [linux-pm] [2.6.30-rc1-git2 regressions] Hibernation broken and (minor but annoying) audio problem
Date: Sun, 12 Apr 2009 11:27:36 -0700 [thread overview]
Message-ID: <49E23298.5050702@linux.intel.com> (raw)
In-Reply-To: <200904122006.57425.rjw@suse.com>
Rafael J. Wysocki wrote:
>
> OK, updated patch follows, with a changelog.
>
> I've added this check to user.c too, because that code can be called
> independently of the one in disk.c . Also, if resume is user space-driven,
> it's a good idea to wait for all of the device probes to complete before
> continuing.
>
> Thanks,
> Rafael
>
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: PM/Hibernate: Wait for SCSI devices scan to complete during resume
>
> There is a race between resume from hibernation and the asynchronous
> scanning of SCSI devices and to prevent it from happening we need to
> call scsi_complete_async_scans() during resume from hibernation.
>
> In addition, if the resume from hibernation is userland-driven, it's
> better to wait for all device probes in the kernel to complete before
> attempting to open the resume device.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
looks like a good fix to me (regardless of the async stuff)
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
next prev parent reply other threads:[~2009-04-12 18:27 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 22:57 [2.6.30-rc1-git2 regressions] Hibernation broken and (minor but annoying) audio problem Rafael J. Wysocki
2009-04-09 23:06 ` Linus Torvalds
2009-04-09 23:06 ` Linus Torvalds
2009-04-10 12:39 ` Rafael J. Wysocki
2009-04-10 12:39 ` Rafael J. Wysocki
2009-04-10 18:58 ` Rafael J. Wysocki
2009-04-10 18:58 ` [linux-pm] " Rafael J. Wysocki
2009-04-10 19:17 ` Linus Torvalds
2009-04-11 0:06 ` Rafael J. Wysocki
2009-04-11 0:06 ` [linux-pm] " Rafael J. Wysocki
2009-04-11 1:19 ` Linus Torvalds
2009-04-11 1:19 ` [linux-pm] " Linus Torvalds
2009-04-11 1:45 ` Arjan van de Ven
2009-04-11 1:45 ` [linux-pm] " Arjan van de Ven
2009-04-11 2:10 ` Arjan van de Ven
2009-04-11 2:10 ` [linux-pm] " Arjan van de Ven
2009-04-11 10:46 ` Rafael J. Wysocki
2009-04-11 10:46 ` Rafael J. Wysocki
2009-04-11 19:38 ` [linux-pm] " Rafael J. Wysocki
2009-04-11 19:55 ` Linus Torvalds
2009-04-11 20:05 ` Arjan van de Ven
2009-04-12 18:06 ` Rafael J. Wysocki
2009-04-12 18:27 ` Arjan van de Ven [this message]
2009-04-12 18:27 ` Arjan van de Ven
2009-04-12 18:06 ` Rafael J. Wysocki
2009-04-11 20:05 ` Arjan van de Ven
2009-04-11 19:55 ` Linus Torvalds
2009-04-11 19:38 ` Rafael J. Wysocki
2009-04-11 1:53 ` Arjan van de Ven
2009-04-11 1:53 ` [linux-pm] " Arjan van de Ven
2009-04-10 19:17 ` Linus Torvalds
2009-04-11 2:35 ` Len Brown
2009-04-11 2:35 ` [linux-pm] " Len Brown
2009-04-11 18:11 ` Linus Torvalds
2009-04-11 19:00 ` Heinz Diehl
2009-04-11 19:00 ` Heinz Diehl
2009-04-11 19:16 ` [linux-pm] " Arjan van de Ven
2009-04-11 19:50 ` Linus Torvalds
2009-04-11 19:50 ` [linux-pm] " Linus Torvalds
2009-04-11 20:11 ` Arjan van de Ven
2009-04-11 20:11 ` [linux-pm] " Arjan van de Ven
2009-04-11 20:18 ` Arkadiusz Miskiewicz
2009-04-11 20:18 ` [linux-pm] " Arkadiusz Miskiewicz
2009-04-11 20:18 ` Arkadiusz Miskiewicz
2009-04-11 19:16 ` Arjan van de Ven
2009-04-11 18:11 ` Linus Torvalds
2009-04-14 12:09 ` Takashi Iwai
2009-04-14 21:12 ` Rafael J. Wysocki
2009-04-14 21:12 ` Rafael J. Wysocki
2009-04-15 13:13 ` Takashi Iwai
2009-04-15 13:13 ` Takashi Iwai
2009-04-15 20:59 ` Rafael J. Wysocki
2009-04-15 20:59 ` Rafael J. Wysocki
2009-04-15 21:05 ` Linus Torvalds
2009-04-15 21:05 ` Linus Torvalds
2009-04-16 6:05 ` Takashi Iwai
2009-04-16 6:05 ` Takashi Iwai
2009-04-16 20:18 ` Rafael J. Wysocki
2009-04-16 20:18 ` Rafael J. Wysocki
2009-04-14 12:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E23298.5050702@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=rjw@suse.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.