From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] tracing/filters: disallow newline as delimeter
Date: Mon, 13 Apr 2009 10:38:40 +0800 [thread overview]
Message-ID: <49E2A5B0.1080802@cn.fujitsu.com> (raw)
In-Reply-To: <49E2A594.4060306@cn.fujitsu.com>
I guess because user input is often ended with '\n' (like "echo xxx"),
thus '\n' is used as a delimeter besides ' ' ? But we can just strip
tailing spaces.
One of the effects of this patch, is fixing this inconsistency:
# echo -n 'parent_comm ==' > filter
bash: echo: write error: Invalid argument
# echo 'parent_comm ==' > filter
# cat filter
parent_comm ==
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/trace/trace_events_filter.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index a63f965..9ef35c1 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -362,7 +362,9 @@ int filter_parse(char **pbuf, struct filter_pred *pred)
char *tok, *val_str = NULL;
int tok_n = 0;
- while ((tok = strsep(pbuf, " \n"))) {
+ strstrip(*pbuf);
+
+ while ((tok = strsep(pbuf, " "))) {
if (tok_n == 0) {
if (!strcmp(tok, "0")) {
pred->clear = 1;
--
1.5.4.rc3
next prev parent reply other threads:[~2009-04-13 2:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 2:38 [PATCH 1/3] tracing/filters: allow user-input to be integer-like string Li Zefan
2009-04-13 2:38 ` Li Zefan [this message]
2009-04-13 2:39 ` [PATCH 3/3] tracing/filters: don't remove old filters when failed to write subsys->filter Li Zefan
2009-04-13 14:45 ` [PATCH 1/3] tracing/filters: allow user-input to be integer-like string Frederic Weisbecker
2009-04-13 22:29 ` Ingo Molnar
2009-04-14 4:21 ` Tom Zanussi
2009-04-14 6:24 ` Li Zefan
2009-04-14 11:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E2A5B0.1080802@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.