From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [patch 1/2] qemu: move pci devfn "first free" assignment to separate function
Date: Mon, 13 Apr 2009 11:08:33 +0300 [thread overview]
Message-ID: <49E2F301.70301@redhat.com> (raw)
In-Reply-To: <20090413035340.221112109@amt.cnet>
Marcelo Tosatti wrote:
> Move pci device address assignment to a separate function.
>
> Index: trunk/hw/pci.c
> ===================================================================
> --- trunk.orig/hw/pci.c
> +++ trunk/hw/pci.c
> @@ -121,6 +121,16 @@ int pci_bus_num(PCIBus *s)
> return s->bus_num;
> }
>
> +int pci_bus_assign_dev_addr(PCIBus *bus)
> +{
> + int devfn;
> +
> + for(devfn = bus->devfn_min ; devfn < 256; devfn += 8)
> + if (!bus->devices[devfn])
> + return devfn;
> + return -1;
> +}
>
s/assign/allocate/ or get_free, to avoid confusion with device
assignment (and given that you aren't assigning anything).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-04-13 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 3:53 [Qemu-devel] [patch 0/2] RFC: move PCI device enumeration out of pci drivers Marcelo Tosatti
2009-04-13 3:53 ` [Qemu-devel] [patch 1/2] qemu: move pci devfn "first free" assignment to separate function Marcelo Tosatti
2009-04-13 8:08 ` Avi Kivity [this message]
2009-04-13 3:53 ` [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to accept devfn Marcelo Tosatti
2009-04-13 12:27 ` Paul Brook
2009-04-13 13:30 ` Marcelo Tosatti
2009-04-13 13:47 ` Brian Wheeler
2009-04-13 14:34 ` Marcelo Tosatti
2009-04-14 3:29 ` Marcelo Tosatti
2009-04-14 8:17 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E2F301.70301@redhat.com \
--to=avi@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.